Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Use stable Rust for source-based code coverage measurement #1902

Open
briansmith opened this issue Jan 13, 2024 · 3 comments · May be fixed by #1987
Open

CI: Use stable Rust for source-based code coverage measurement #1902

briansmith opened this issue Jan 13, 2024 · 3 comments · May be fixed by #1987
Assignees
@Raghav-Bell
Labels
good-first-bug

Comments

@briansmith
Copy link
Owner

Rust 1.76 is scheduled to be released on Feburary 8th, 2024. Assuming it continues to include the change in rust-lang/rust#118100, we should switch all the coverage jobs in ci.yml to use Rust Stable instead of Rust Nightly.
@briansmith
Copy link
Owner Author

See also #1903 about using llvm-tools-preview for processing the code coverage data, instead of external llvm-tools.

@Raghav-Bell
Copy link

@briansmith if this issue is still open, please assign this issue to me. Thanks

@briansmith
Copy link
Owner Author

@Raghav-Bell Thanks! I have assigned it to you. I also submitted the last change related to this that I had locally: PR #1984.

@Raghav-Bell Raghav-Bell linked a pull request Mar 8, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Raghav-Bell Raghav-Bell

Labels
good-first-bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changed toolchain to stable for coverage Raghav-Bell/ring
2 participants
@briansmith @Raghav-Bell