Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

focus on first input does not work when "closeOnEsc=true" #31

Open
alex-jitbit opened this issue Jan 29, 2019 · 3 comments
Open

focus on first input does not work when "closeOnEsc=true" #31

alex-jitbit opened this issue Jan 29, 2019 · 3 comments

Comments

@alex-jitbit
Copy link

Because focus() is being called AGAIN on esc-binding
alex-jitbit added a commit to alex-jitbit/jqModal that referenced this issue Jan 29, 2019
@alex-jitbit
fix briceburg#31
6ebd11d
@alex-jitbit
Copy link
Author

proposed PR to fix this (above)

@alex-jitbit
Copy link
Author

alex-jitbit commented Jan 29, 2019 •
edited
Loading

Sorry, I was on an older version. Appears to be fixed already

@alex-jitbit alex-jitbit reopened this Jan 29, 2019
@alex-jitbit
Copy link
Author

Spoke too fast :)) sorry for the mess.

@alex-jitbit alex-jitbit changed the title focus on first input does not work focus on first input does not work when "closeOnEsc=true" Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alex-jitbit