New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scripts or tests? #4

Open

tngTUDOR opened this issue Sep 18, 2022 · 0 comments

Contributor

tngTUDOR commented Sep 18, 2022

we could also use a test runner to let the contributor verify his work before commit/push

downsides:

contributor must also know about the test runner (pytest, nox, unit, etc.)
actions need one more dependency: the test runner

advantages:

test semantics is a bit easier to understand: if the tests pass, the CI pipeline associated to the pull request is safe. This is somehow the expected semantics from a developer point of view (as opposed to a contributor )
we should enforce using tests in the ecosystem

@cmutel What do you think ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment