Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show methods for Style Objects Should Be Improved #59

Open
brodieG opened this issue Aug 19, 2016 · 0 comments
Open

Show methods for Style Objects Should Be Improved #59

brodieG opened this issue Aug 19, 2016 · 0 comments
Milestone

Comments

@brodieG
Copy link
Owner

brodieG commented Aug 19, 2016

Right now there is branching logic within the show-style method based on whether the style is an ansi style or not, when ideally this would be handled via S4 dispatch if possible. Additionally, StyleHtml do not display to browser. One tension to resolve here is whether the show-Style methods should be exclusively for the terminal, particularly because they are used by show-PaletteOfStyles and mixed outputs will not work well.

One other reason to address this is that users could potentially define new styles (e.g. grid graphics) and this seems to be one of the places that assumes styles are either ANSI or html.

@brodieG brodieG added this to the 0.2 milestone Aug 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant