Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line-break each argument in TS class constructor definitions #757

Open
richburdon opened this issue Oct 26, 2022 · 0 comments
Open

Line-break each argument in TS class constructor definitions #757

richburdon opened this issue Oct 26, 2022 · 0 comments

Comments

@richburdon
Copy link

richburdon commented Oct 26, 2022

Constructors allow direct setting of member variables, but these are obscured if left on a single line:

For example, in the block below it's easy to miss the key member variable.

export class TestPeer<M extends Model> {
  public timeframe = new Timeframe();
  public mutations: ModelMessage<Uint8Array>[] = [];

  constructor(public readonly stateManager: StateManager<M>, public readonly key: PublicKey) {}

  get model(): M {
    return this.stateManager.model;
  }
}

Versus this:

export class TestPeer<M extends Model> {
  public timeframe = new Timeframe();
  public mutations: ModelMessage<Uint8Array>[] = [];

  constructor(
    public readonly stateManager: StateManager<M>,
    public readonly key: PublicKey
  ) {}

  get model(): M {
    return this.stateManager.model;
  }
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant