prettierx: Merge Prettier 2.3.0 updates - draft 1 #549

adalinesimonian · 2021-05-23T20:31:47Z

Closes #548
Closes #414

Many, many hours of work later, this is starting to look good! Still needs work, though.

Merge conflicts have been resolved, moving the appropriate changes in prettierx into their corresponding new locations with the multiple refactors made upstream. ~~However, about 374 out of 1189 test suites are failing - one, for example, because parentheses are not correctly being printed around multi-line conditionals.~~

These failing tests shouldn't be that hard to resolve; it seems that in most of the cases, at least from a cursory glance, multiple tests are failing due to the same sets of bugs created from the merge. It will take a bit of effort and time to resolve but then again, so does merging a massive amount of changes into a fork and, well, at least that's mostly done now!

~~Tests now pass (at least locally)!~~ ~~Actually, it turns out there are 4 test suites that still fail - I hadn't run them because I was unaware of the FULL_TEST flag.~~ Test failures resolved.

I've enabled edits by maintainers so if y'all would like to have a crack at anything, please, be my guest. In the meantime, I'll keep trying to iron this stuff out.

Make test suites pass
- 374 failing → 0 failing
Write any new tests, if necessary
Make sure that dependency changes in prettierx, such as flow being optional, are still in effect if possible to keep
Ensure CI/workflows are valid
Conform changes to lint rules
Document changes
Clean-up

Co-authored-by: Renovate Bot <[email protected]>

…odycj#500) Co-authored-by: Renovate Bot <[email protected]>

Co-authored-by: Renovate Bot <[email protected]>

and update a test snapshot

Co-authored-by: Renovate Bot <[email protected]>

do not enable code coverage in .github/workflows/dev-test.yml

Co-authored-by: Renovate Bot <[email protected]>

(should avoid some security warnings reported by GitHub)

…rodycj#374) Bumps [node-fetch](https://github.com/bitinn/node-fetch) from 2.1.2 to 2.6.1. - [Release notes](https://github.com/bitinn/node-fetch/releases) - [Changelog](https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md) - [Commits](node-fetch/node-fetch@v2.1.2...v2.6.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Co-authored-by: Renovate Bot <[email protected]>

…odycj#510) Co-authored-by: Renovate Bot <[email protected]>

(seems to remove an extra semver entry from yarn.lock as well) to avoid an extra dependency warning effectively reverts 44343c4 (PR brodycj#515)

* remove jest-watch-typeahead from devDependencies * remove snapshot-diff from devDependencies * remove jest from devDependencies * remove babel-loader from devDependencies * remove terser-webpack-plugin from devDependencies * remove webpack from devDependencies * add jest (version 26.6.3) to devDependencies * add jest-watch-typeahead (version 0.6.2) to devDependencies * add snapshot-diff (version 0.8.1) to devDependencies * add [email protected] to devDependencies * add babel-loader (version 8.2.2) to devDependencies * add [email protected] to devDependencies

Co-authored-by: Renovate Bot <[email protected]>

…odycj#521) Co-authored-by: Renovate Bot <[email protected]>

adalinesimonian · 2021-06-07T18:41:20Z

Didn't realise renaming the branch would close this PR. Superceded by #569

(with limited updates needed in src/language-js/needs-parens.js) based on some updates from: - #549 - #569 TODO items: - include test updates from prettierX dev branch - update documentation Co-authored-by: Adaline Valentina Simonian <[email protected]> Co-authored-by: Christopher J. Brody <[email protected]>

to be more consistent with prettierX 0.18.x including some updates from: - #549 - #569 Co-authored-by: Christopher J. Brody <[email protected]> Co-authored-by: Adaline Valentina Simonian <[email protected]>

with some help from updates proposed in: - #549 - #569 Co-authored-by: Christopher J. Brody <[email protected]> Co-authored-by: Adaline Valentina Simonian <[email protected]>

(in prettierx-update-branch-001) based on some updates from: - #549 - #569 (with very limited update needed in src/language-js/needs-parens.js) TODO items: - include test updates from prettierX dev branch - update documentation Co-authored-by: Adaline Valentina Simonian <[email protected]> Co-authored-by: Christopher J. Brody <[email protected]>

to be more consistent with prettierX 0.18.x including some updates from: - #549 - #569 Co-authored-by: Christopher J. Brody <[email protected]> Co-authored-by: Adaline Valentina Simonian <[email protected]>

(in prettierx-update-branch-0010) based on some updates from: - #549 - #569 (with very limited update needed in src/language-js/needs-parens.js) TODO items: - include test updates from prettierX dev branch - update documentation Co-authored-by: Adaline Valentina Simonian <[email protected]> Co-authored-by: Christopher J. Brody <[email protected]>

to be more consistent with prettierX 0.18.x including some updates from: - #549 - #569 Co-authored-by: Christopher J. Brody <[email protected]> Co-authored-by: Adaline Valentina Simonian <[email protected]>

into prettierx-rebase-branch-001 based on some updates from: - #549 - #569 - #603 (with very limited update needed in src/language-js/needs-parens.js) **tested** with prettierX-specific test cases from prettierX 0.18.x TODO items: - include test updates from prettierX dev branch - update documentation Co-authored-by: Adaline Valentina Simonian <[email protected]> Co-authored-by: Christopher J. Brody <[email protected]>

into prettierx-rebase-branch-001 based on some updates from: - #549 - #569 - #603 (with a very limited update needed in src/language-js/needs-parens.js) **tested** with prettierX-specific test cases from prettierX 0.18.x TODO items: - include test updates from prettierX dev branch - update documentation Co-authored-by: Adaline Valentina Simonian <[email protected]> Co-authored-by: Christopher J. Brody <[email protected]>

to be more consistent with prettierX 0.18.x including some updates from: - #549 - #569 - #603 Co-authored-by: Christopher J. Brody <[email protected]> Co-authored-by: Adaline Valentina Simonian <[email protected]>

into prettierx-rebase-branch-001 based on some updates from: - #549 - #569 - #603 (with a very limited update needed in src/language-js/needs-parens.js) **tested** with prettierX-specific formatting test cases from prettierX 0.18.x (discovered a very limited number of changes from prettierX 0.18.x) TODO items: - include test updates from prettierX dev branch - update documentation Co-authored-by: Adaline Valentina Simonian <[email protected]> Co-authored-by: Christopher J. Brody <[email protected]>

to be more consistent with prettierX 0.18.x including some updates from: - #549 - #569 - #603 Co-authored-by: Christopher J. Brody <[email protected]> Co-authored-by: Adaline Valentina Simonian <[email protected]>

into prettierx-rebase-branch-001 based on some updates from: - #549 - #569 - #603 with a very limited update needed in src/language-js/needs-parens.js and with comments where the updates are NO LONGER NEEDED in src/language-js/needs-parens.js tested with prettierX-specific formatting test cases from prettierX 0.18.x (discovered a very limited number of deviations) TODO items: - include test updates from prettierX dev branch - update documentation Co-authored-by: Adaline Valentina Simonian <[email protected]> Co-authored-by: Christopher J. Brody <[email protected]>

into prettierx 0.19.0-01-update-branch based on some updates from: - #549 - #569 - #603 with a very limited update needed in src/language-js/needs-parens.js and with comments where updates from 0.18.x are NO LONGER NEEDED in src/language-js/needs-parens.js tested with prettierX-specific formatting test cases from prettierX 0.18.x (discovered a very limited number of deviations) TODO items: - include test updates from prettierX dev branch - update documentation Co-authored-by: Adaline Valentina Simonian <[email protected]> Co-authored-by: Christopher J. Brody <[email protected]>

renovate bot and others added 30 commits March 22, 2021 21:32

prettierx: Update eslint -> 7.22.0 - devDependency (brodycj#498)

40c92b5

Co-authored-by: Renovate Bot <[email protected]>

prettierx: Update @rollup/plugin-replace -> 2.4.2 - devDependency (br…

ae334ac

…odycj#500) Co-authored-by: Renovate Bot <[email protected]>

prettierx: Update execa -> 5.0.0 - devDependency (brodycj#485)

a9bfe7e

Co-authored-by: Renovate Bot <[email protected]>

prettierx: Update tempy -> 1.0.1 - devDependency (brodycj#491)

35e38a3

Co-authored-by: Renovate Bot <[email protected]>

prettierx: update @babel/core -> 7.13.15 --dev

e984cf9

prettierx: update @babel/preset-env -> 7.13.15 --dev

de86fb3

prettierx: update eslint -> 7.24.0 --dev

abad553

prettierx: update eslint-plugin-react -> 7.23.2 --dev

a9fa6f3

prettierx: update jest-watch-typeahead -> 0.6.2 --dev

e9a1092

prettierx: update @babel/code-frame -> 7.12.13 (...)

d1d4b76

and update a test snapshot

prettierx: Update ci-info -> 3.1.1 - dependency (brodycj#480)

98aa7b3

Co-authored-by: Renovate Bot <[email protected]>

prettierx: Update diff -> 5.0.0 - dependency (brodycj#482)

70a73ff

Co-authored-by: Renovate Bot <[email protected]>

prettierx: Update globby -> 11.0.3 - dependency (brodycj#499)

d2ea597

Co-authored-by: Renovate Bot <[email protected]>

prettierx: Update mem -> 8.1.0 - dependency (brodycj#486)

9ac0586

Co-authored-by: Renovate Bot <[email protected]>

prettierx: Update postcss-less -> 4.0.1 - dependency (brodycj#487)

148baca

Co-authored-by: Renovate Bot <[email protected]>

prettierx: Update semver -> 7.3.5 - dependency (brodycj#508)

af9e719

Co-authored-by: Renovate Bot <[email protected]>

prettierx: Update rollup -> 2.45.1 - devDependency (brodycj#507)

4be76fe

Co-authored-by: Renovate Bot <[email protected]>

prettierx: no code coverage in GitHub action

bb0d7f3

do not enable code coverage in .github/workflows/dev-test.yml

prettierx: Update resolve -> 1.20.0 - dependency (brodycj#465)

3c88783

Co-authored-by: Renovate Bot <[email protected]>

prettierx: remove Prettier website code

aa12c04

(should avoid some security warnings reported by GitHub)

prettierx: Update tslib -> 2.2.0 - dependency (brodycj#515)

44343c4

Co-authored-by: Renovate Bot <[email protected]>

prettierx: Update eslint-plugin-unicorn -> 29.0.0 - devDependency (br…

ca0120d

…odycj#510) Co-authored-by: Renovate Bot <[email protected]>

prettierx: tslib back to 1.14.1

faf2593

(seems to remove an extra semver entry from yarn.lock as well) to avoid an extra dependency warning effectively reverts 44343c4 (PR brodycj#515)

prettierx: update dependencies notes in package.json

c5ef079

prettierx: version 0.18.0

ec29f1c

prettierx: start 0.18.1-dev

b2b1aab

prettierx: Update rollup -> 2.45.2 - devDependency (brodycj#520)

1580da4

Co-authored-by: Renovate Bot <[email protected]>

prettierx: Update eslint-config-prettier -> 8.2.0 - devDependency (br…

c7a9032

…odycj#521) Co-authored-by: Renovate Bot <[email protected]>

adalinesimonian mentioned this pull request Jun 7, 2021

prettierx: Merge Prettier 2.3.1 updates - draft 2 #569

Closed

8 tasks

brodycj changed the title ~~prettierx: Merge Prettier 2.3.0 updates~~ prettierx: Merge Prettier 2.3.0 updates - draft 1 Jun 22, 2021

adalinesimonian mentioned this pull request Jul 6, 2021

Merge additional changes from adalinesimonian/merge-prettier-2.3.1 #603

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

prettierx: Merge Prettier 2.3.0 updates - draft 1 #549

prettierx: Merge Prettier 2.3.0 updates - draft 1 #549

adalinesimonian commented May 23, 2021 •

edited

Loading

adalinesimonian commented Jun 7, 2021

prettierx: Merge Prettier 2.3.0 updates - draft 1 #549

prettierx: Merge Prettier 2.3.0 updates - draft 1 #549

Conversation

adalinesimonian commented May 23, 2021 • edited Loading

adalinesimonian commented Jun 7, 2021

adalinesimonian commented May 23, 2021 •

edited

Loading