[WIP] prettierx refactor!: fix & update balanced ternary formatting support - DRAFT WIP

[brodycj]

(BREAKING CHANGE)

resolves #468

Status: DRAFT WIP

TODO:

• update more test snapshots
• rename existing option as discussed in v0.20.0 with BREAKING CHANGES - ternary expressions formatting updates coming again #493
• consider possible workaround for issue [prettierx] ternary formatting with objects & tabs needs improvement in upstream Prettier #552
• consider making some progress on [prettierx] more flexible ternary conditional expression formatting #585
• update option text as needed
• update some more documentation
• cleanup code changes, as needed
• update title of this PR

[brodycj]

From a closer look at some snapshot changes at this point with update from PR #492, with tabWidth: 4:

@@ -60,13 +60,13 @@ let isSpace = false;
 
 const dress = isSpace
     ? {
-        spaceSuit: 3,
-        oxygenCylinders: 6
-    }
+          spaceSuit: 3,
+          oxygenCylinders: 6
+      }
     : {
-        shirts: 3,
-        paints: 3
-    };
+          shirts: 3,
+          paints: 3
+      };
 
 ================================================================================
 `;

The alignment of the inner object members in this diff felt little off to me with my magnified terminal font. I think this is because the inner object members have an indentation of 10 spaces, while most of the other lines have an indentation of 4 or 6 spaces.

I am now thinking that it would be best to use an option to remove the ternary indenting, like "--no-ternary-inner-indent" as discussed in #585 in case of tab width > 2 spaces or --use-tabs option.

P.S. I think this comment is a manifestation of this issue: prettier/prettier#4203

[brodycj]

Here is the diff from my terminal with display tab width of 8:

@@ -96,13 +96,13 @@ let isSpace = false;
 
 const dress = isSpace
        ? {
-               spaceSuit: 3,
-               oxygenCylinders: 6
-       }
+                       spaceSuit: 3,
+                       oxygenCylinders: 6
+         }
        : {
-               shirts: 3,
-               paints: 3
-       };
+                       shirts: 3,
+                       paints: 3
+         };
 
 ================================================================================
 `;

I think a workaround like using a "--no-ternary-inner-indent" option as discussed in #585 is clearly needed when using the balanced ternary formatting option together with --use-tabs.

P.S. I think this observation is a manifestation of issue #552, as I reported in this comment: prettier/prettier#4203 (comment)

[moussaab-moulim]

hello @brodybits
just a question is this package is still working
is it suitable to be used now
i can see that it has been 3 years since last update there a lot of things that i would live to have in my project but this is scaring me