Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to add ? #1

Open
tellfa opened this issue Oct 5, 2015 · 5 comments
Open

how to add ? #1

tellfa opened this issue Oct 5, 2015 · 5 comments

Comments

@tellfa
Copy link

tellfa commented Oct 5, 2015

hi, tnx for this great project. but i can't add this project to Android Studio :(
please add build.gradle code, for example : compile 'com.android.support:appcompat-v7:22.2.1'

tnx dear friend

@brucetoo
Copy link
Owner

brucetoo commented Oct 5, 2015

Hmmm..By now,this lib is not strong enough to into Jcenter or Maven. U just need copy PinterestView into to ur project,then everything will gonna under control.

@tellfa
Copy link
Author

tellfa commented Oct 5, 2015

build.gradle code in very easy way 😄
please add this, pleasssssssssssssssssssssssssse ❤️

@KANGOD
Copy link

KANGOD commented Jan 12, 2017

@brucetoo Maybe we could use jitpack for a convenient workaround.

jitpack does support specifying a commit hash instead of git tag. But for now, compile 'com.github.brucetoo:PinterestView:e43ecd3' generates an apk file at <gradle_path>\.gradle\caches\modules-2\files-2.1\com.github.brucetoo\PinterestView\e43ecd3\e2e0ec66e4b831d55e655156fedeb4f29a14aa64\PinterestView-e43ecd3.apk, not an aar.

I think it would be enough to separate this repo to 2 modules, demo and library, with apply plugin: 'com.android.library'. Then we can add this repo in build.gradle.

Furthermore, you could git tag a release, 0.1-beta or 0.1-SNAPSHOT or 0.0.1 or something, for the compile 'com.github.brucetoo:PinterestView:0.1' looks more pretty than the commit hash version.

@brucetoo
Copy link
Owner

@KANGOD thanks for suggestion.But as i said before, this lib is not strong enough to be as a library.There still are problems need to be fixed.

@KANGOD
Copy link

KANGOD commented Jan 16, 2017

@brucetoo OK, instead of adding it in gradle, I will go through your code for inspiration, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants