This repository has been archived by the owner on Jul 7, 2024. It is now read-only.
Refactor mixed_canonize!
#14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jofrevalles
reviewed
Feb 22, 2024
jofrevalles
suggested changes
Feb 22, 2024
jofrevalles
suggested changes
Feb 22, 2024
mofeing
force-pushed
the
refactor-canonize
branch
from
0c84111 to
9a20417
Compare
|
The CI is failing because some weird interaction with the master version of Tenet. Merging because all tests pass in my computer. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just discovered some things from #10 that wasn't convinced about.
modekwarg incanonize_site!would be better named asmethodmixed_canonize!Something not yet addressed in this PR is that if we use the
:svdmethod incanonize_site!, then we cannot properly mixed-canonize aChainwithout also contracting the "spectrum vector" with the next tensor.