This repository has been archived by the owner on Jul 7, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Extend Tenet.contract
to contract :between
two Site
s
#30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mofeing
suggested changes
Mar 13, 2024
Co-authored-by: Sergio Sánchez Ramírez <[email protected]>
mofeing
reviewed
Mar 13, 2024
mofeing
reviewed
Mar 14, 2024
mofeing
suggested changes
Mar 14, 2024
mofeing
reviewed
Mar 14, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #30 +/- ##
=======================================
Coverage 75.00% 75.00%
=======================================
Files 8 8
Lines 436 460 +24
=======================================
+ Hits 327 345 +18
- Misses 109 115 +6 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Sergio Sánchez Ramírez <[email protected]>
mofeing
approved these changes
Mar 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances the
Tenet.contract
function, enabling it tocontract
the singular values within a bond between twoSite
s. It introduces an optionaldirection
argument, allowing users to specify whether the singular values should be contracted onto the:left
or the:right
tensor.Additionally, we have added tests for this new functionality, and refactored the existing tests for the
canonize!
function, resulting in more compact and efficient test code.Example:
Let's exemplify the function: