Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import fails on windows 10 #153

Open
croots opened this issue May 14, 2020 · 2 comments
Open

Import fails on windows 10 #153

croots opened this issue May 14, 2020 · 2 comments

Comments

@croots
Copy link

croots commented May 14, 2020

Describe the bug
When attempting to import class files, skript throws exception.

To reproduce
Rename attached skript to filetype .sk and run in
a windows environment.

Expected behavior
Import behaves cleanly as it does on linux-based OS's

Server information

  • skript-mirror: 1.0.0 & 0.19.1
  • Skript: 2.4.1
  • Bukkit: Paper 283
  • Minecraft: 1.15.2
  • Java: Build 1.8.0_251-b08
  • OS: Windows Version 10.0.18363 Build 18363

Additional context
Thrown error attached.

All scripts seem to work fine after /skript reload all, issue only seems to occur for first script alphabetically. Perhaps Skript is trying to load scripts on windows before skript-mirror is totally initialized?

errortestskript.txt

error.log

@croots
Copy link
Author

croots commented May 14, 2020

Appears to be fixed in 2.0.0 snapshot? I don't see anything about it in the issue tracker so it might be useful to add a check somewhere if the fix was unintentional to prevent a future update from breaking again.

@btk5h
Copy link
Owner

btk5h commented May 14, 2020

Yes, I believe this was not an OS-specific issue, but rather an issue with how 1.X hacks around Skript's logger to disable certain warnings. In recent versions of Skript, Skript's logger implementation changed, breaking this hack.

This logger hack has been removed in the 2.X branch (and there are no plans to add it back), but it's worth backporting the fix to 1.X as well. I'll try to fix that this weekend, assuming the fix is relatively quick to make.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants