-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event handler ignore cancel doesn't work #154
Comments
so @btk5h , do you have an idea ? ... |
Not enough information to reproduce, can you post more information (plugin versions, setting up regions, etc.) on how to replicate this on a fresh server? |
I'll try to replicate this on a fresh server, i tell you |
Hey, i just try on a 1.12.2 PaperSpigot version, clean install, skript version 2.2-dev36 |
bump |
bump :/ |
I have my suspicions on what could be causing this, does your script work if you remove the "all" keyword? |
Yes it work but when the event is cancelled, it don’t work. So it’s the |
Anyone looking into this issue might want to look into making sure the ignoreCancelled flag is being set properly skript-mirror/src/main/java/com/btk5h/skriptmirror/skript/reflect/EvtByReflection.java Line 126 in 6e4e8bf
and make sure the ignoreCancelled flag actually works when registering an event. skript-mirror/src/main/java/com/btk5h/skriptmirror/skript/reflect/EvtByReflection.java Line 100 in 6e4e8bf
|
Thanks for help, so i have to wait for an update? |
up ^^ |
Fixed: #21 #19 #7 btk5h/skript-mirror#122 (the warning, but that was the only thing wrong with it) btk5h/skript-mirror#154 (partly, see #22) Added: warnings for using features that require consent when no consent is given cancellability for custom events (see https://skript-mirror-tp.gitbook.io/skript-mirror-tp/advanced/custom-syntax/events#calling-the-event)
On my server, i have Factions and WorldGuard and when i use this script:
https://pastebin.com/D3hMASxX
I can listen to the event but when i'm in warzone (build is disabled) or in a region where build is disabled, the script don't work and i don't know why ?
Server information
The text was updated successfully, but these errors were encountered: