Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please support setPrototypeOf instead of __proto__ #281

Open
kapouer opened this issue Sep 14, 2022 · 1 comment · May be fixed by #282
Open

Please support setPrototypeOf instead of __proto__ #281

kapouer opened this issue Sep 14, 2022 · 1 comment · May be fixed by #282

Comments

@kapouer
Copy link

kapouer commented Sep 14, 2022

According to MDN docs on proto, all A.__proto__ = B should actually be Object.setPrototypeOf(A, B).
__proto__ is only allowed to keep compatibility, and represents a huge security vulnerability surface.
This would also allow "hardening" nodejs with --disable-proto=delete|throw.
@guimard guimard linked a pull request Sep 14, 2022 that will close this issue
Open
@guimard
Copy link

guimard commented Sep 14, 2022

#282 fixes this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't use __proto__ in transpilation guimard/buble
2 participants
@guimard @kapouer