Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalization during test #41

Open
gusalsdmlwlq opened this issue Oct 19, 2020 · 2 comments
Open

Normalization during test #41

gusalsdmlwlq opened this issue Oct 19, 2020 · 2 comments

Comments

@gusalsdmlwlq
Copy link
Contributor

Hi.

val2 = normalize(val2)

text = re.sub(timepat, ' [value_time] ', text)

In this line, the values of belief state are normalized before searching DB.

But, the time values of train(leaveAt, arrvieBy) are also normalized to [value_time].

In this case, I think we cannot check whether the values meet the user's goal, right?

Is it intended?

@budzianowski
Copy link
Owner

Hi, thanks for catching this! It's a bug!
However, due to backwards compatibility with previous results, it won't be easy to fix that straight away.
I will try to come up with a good solution.

@gusalsdmlwlq
Copy link
Contributor Author

Thanks for relpy!
Well, I'll leave this issue open.
If you want or resolve, close this issue please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants