From 90da6bb244845f1add6f2e98d5cbbb6a215d9917 Mon Sep 17 00:00:00 2001
From: Pablo Polvorin <pablo@ockam.io>
Date: Mon, 2 Oct 2023 21:04:43 -0300
Subject: [PATCH] feat(elixir): adapt to changes on authority api

mainly on use of binary identity identifiers rather than the string
format.
---
 .../credential/authenticator/direct/client.ex | 22 ++++++++++++++-----
 1 file changed, 17 insertions(+), 5 deletions(-)

diff --git a/implementations/elixir/ockam/ockam/lib/ockam/credential/authenticator/direct/client.ex b/implementations/elixir/ockam/ockam/lib/ockam/credential/authenticator/direct/client.ex
index 12ca54d3513..86aab8b142a 100644
--- a/implementations/elixir/ockam/ockam/lib/ockam/credential/authenticator/direct/client.ex
+++ b/implementations/elixir/ockam/ockam/lib/ockam/credential/authenticator/direct/client.ex
@@ -6,7 +6,11 @@ defmodule Ockam.Credential.Authenticator.Direct.Client.AddMemberRequest do
 
   typedstruct do
     plugin(Ockam.TypedCBOR.Plugin)
-    field(:identity_id, binary(), minicbor: [key: 1])
+
+    field(:identity_id, Ockam.Identity.Identifier.t(),
+      minicbor: [key: 1, schema: Ockam.Identity.Identifier]
+    )
+
     field(:attributes, %{String.t() => String.t()}, minicbor: [key: 2])
   end
 end
@@ -17,13 +21,16 @@ defmodule Ockam.Credential.Authenticator.Direct.Client.AttributesEntry do
   """
   use TypedStruct
 
+  alias Ockam.Identity.Identifier
+
   typedstruct do
     plugin(Ockam.TypedCBOR.Plugin)
     ## Rust encodes attribute values as a list of bytes
     field(:attributes, %{{:list, :integer} => {:list, :integer}}, minicbor: [key: 1])
     field(:added_at, integer(), minicbor: [key: 2])
     field(:expires, integer() | nil, minicbor: [key: 3])
-    field(:attested_by, binary() | nil, minicbor: [key: 4])
+
+    field(:attested_by, Identifier.t() | nil, minicbor: [key: 4, schema: Identifier])
   end
 end
 
@@ -35,8 +42,9 @@ defmodule Ockam.Credential.Authenticator.Direct.Client.ListMembersResponse do
   """
 
   alias Ockam.Credential.Authenticator.Direct.Client.AttributesEntry
+  alias Ockam.Identity.Identifier
 
-  @schema {:map, :string, AttributesEntry.minicbor_schema()}
+  @schema {:map, :binary, AttributesEntry.minicbor_schema()}
 
   def decode_strict(data) do
     with {:ok, decoded} <- Ockam.TypedCBOR.decode_strict(@schema, data) do
@@ -50,7 +58,7 @@ defmodule Ockam.Credential.Authenticator.Direct.Client.ListMembersResponse do
              {:erlang.list_to_binary(key), :erlang.list_to_binary(val)}
            end)
 
-         {id, Map.put(entry, :attributes, attributes)}
+         {%Identifier{id: id}, Map.put(entry, :attributes, attributes)}
        end)}
     end
   end
@@ -70,7 +78,11 @@ defmodule Ockam.Credential.Authenticator.Direct.Client do
   alias Ockam.Credential.Authenticator.Direct.Client.AttributesEntry
   alias Ockam.Credential.Authenticator.Direct.Client.ListMembersResponse
 
-  @spec add_member(String.t(), %{String.t() => String.t()}, Ockam.Address.route()) ::
+  @spec add_member(
+          Ockam.Identity.Identifier.t(),
+          %{String.t() => String.t()},
+          Ockam.Address.route()
+        ) ::
           :ok | {:error, any()}
   def add_member(identity_id, attributes, api_route) do
     request =