Make Placeholder a type that can be convered to Painter #5306
Conversation
|
@kanelbulle can you let me know how painful removing the subcomposition variants of placeholder would be? I could keep them around for a while longer as special cases, but it would be nice to remove them. |
|
@kanelbulle let me know what you think |
|
Thanks for checking, I think we can remove it, but it would be nice to have it @deprecated for a month or two first if it's not too much trouble. We have less than 10 usages in a couple of different projects so it's not completely trouble-free. |
sjudd
force-pushed
the
more_robust_placeholder
branch
from
9eb82a3 to
6e0f66f
Compare
Ok it turns out it's kind of annoying to get it to work again with the refactor... so I've left the API in but it doesn't work. I'm a real Android engineer now right? At least it'll compile when you import it |
This removes the deprecated Composable variant of Placeholder. Users who require that functionality should instead use GlideSubcomposition. It's useful to remove this now because it allows for a much simpler Placholder interface and it unblocks us from moving most of GlideImage into GlideModifier. In turn that will let us expose GlideModifier as a real composable API component.
sjudd
force-pushed
the
more_robust_placeholder
branch
from
6e0f66f to
1774819
Compare
This removes the deprecated Composable variant of Placeholder. Users who require that functionality should instead use GlideSubcomposition. It's useful to remove this now because it allows for a much simpler Placholder interface and it unblocks us from moving most of GlideImage into GlideModifier. In turn that will let us expose GlideModifier as a real composable API component.