Ansible 2.4 EL6 module error

[bigHosting]

II just tried this on Ansible 2.4 & EL6 and I got errors :(

• hosts: all
  gather_facts: yes
  serial: "25%"
  sudo: yes
  tasks:
  • name: set timeout to 22
    grub: timeout=22

Error:

TASK [set timeout to 22] ********************************************************************************************************************************************
fatal: [mal0c0]: FAILED! => {"changed": false, "failed": true, "module_stderr": "Shared connection to mal0c0 closed.\r\n", "module_stdout": "\r\nTraceback (most recent call last):\r\n File "/tmp/ansible_7xlrIz/ansible_module_grub.py", line 454, in \r\n main()\r\n File "/tmp/ansible_7xlrIz/ansible_module_grub.py", line 441, in main\r\n (rc, changed, msg) = grub.set_timeout()\r\n File "/tmp/ansible_7xlrIz/ansible_module_grub.py", line 392, in set_timeout\r\n return self._grub_set_timeout()\r\n File "/tmp/ansible_7xlrIz/ansible_module_grub.py", line 361, in _grub_set_timeout\r\n if self._grub_save_config(contents) is not True:\r\nNameError: global name 'contents' is not defined\r\n", "msg": "MODULE FAILURE", "rc": 0}

[bushvin]

Thank you for spotting this error. I believe it should be fixed now.

[bigHosting]

Thank you, now definitely is better as there is no error. functionality wise the line gets substituded with 'R' so instead of timeout=22 I see 'R' on a single line where timeout=5 used to be .

[bushvin]

I found the problem, and fixed it.
I also did a major overhaul of the codebase.
It now supports --diff as well.