Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update swift files to swift 3 #40

Open
evgenybruhachev opened this issue Sep 22, 2016 · 10 comments
Open

update swift files to swift 3 #40

evgenybruhachev opened this issue Sep 22, 2016 · 10 comments
Assignees

Comments

@evgenybruhachev
Copy link

No description provided.

@dmauro dmauro self-assigned this Sep 22, 2016
@wods
Copy link

wods commented Sep 29, 2016

HI,
Is there any update for this issue?

Thanks,

@dmauro
Copy link
Contributor

dmauro commented Sep 29, 2016

It might be a bit. We don't have plans to move over to Swift 3 internally just yet, so I'm not handy with it yet. I'll take a stab at it, but would also love a hand with it (I'll mark it as such).

@wods
Copy link

wods commented Sep 30, 2016

Thanks.

@ChokWah
Copy link

ChokWah commented May 11, 2017

It 's 2017now. Is there any update for this issue?

@tvstuff
Copy link

tvstuff commented Jul 25, 2017

Any update on this yet?

@dmauro
Copy link
Contributor

dmauro commented Jul 25, 2017

I started working on this in some of my free time since it's not a priority for us. Still would love to get some help though if anyone is interested.

@abanobmikaeel
Copy link

abanobmikaeel commented Aug 14, 2017

Currently working on the swift 3 migration running into issues with
'dispatch_once_t' is unavailable in Swift: Use lazily initialized globals instead
Any suggestions? @dmauro

@dmauro
Copy link
Contributor

dmauro commented Aug 14, 2017

Oh, awesome, glad to see someone is helping out with this, thank you! Yeah so for dispatch_once_t you should just use the a static var instead probably. Which line is this you're dealing with specifically?

@abanobmikaeel
Copy link

abanobmikaeel commented Aug 14, 2017

Glad to help. DiskCache line 33 mainly.

@dmauro
Copy link
Contributor

dmauro commented Aug 14, 2017

Ahhh, I think we should actually abandon that altogether and use something like this instead where we would otherwise reference that variable:

if #available(iOS 8.0, *) {
    // equivalent to isAtLeastiOS8
} else {
    // use the old crappier APIs
}

For other cases though where you can't just drop the dispatch once, static var is probably the way to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants