Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot set custom snooze date when in overlow menu as button is missing #487

Open
rugk opened this issue Aug 16, 2021 · 5 comments
Open
Labels
needinfo Needs a reply from the reporter.

Comments

@rugk
Copy link
Contributor

rugk commented Aug 16, 2021

STR

  1. Put the button into the overflow menu (i.e. that >> icon).
  2. Open it there and open it and select to "Pick a custom date/time".

What happens

The height is way too large and thus, you cannot click/choose the button to accept the date/time you've entered.

image
image2

What should happen

I should see the buttons and be able to click them.

Workaround

You can zoom in and suddenly you will see some buttons at the bottom.

Or of course move it into the toolbar or so.

Potential solution

I know this menu is a hard weird thing and so on. Maybe you can just set a height as a workaround (for now)?

System

Firefox 90.0.2
Fedora 34, GNOME

@bwinton
Copy link
Owner

bwinton commented Aug 29, 2021

Are you still seeing this? I checked in Fx91 on MacOS, and can't reproduce it…

@bwinton bwinton added the needinfo Needs a reply from the reporter. label Aug 29, 2021
@rugk
Copy link
Contributor Author

rugk commented Aug 29, 2021

Yes I do see this with Firefox 91.0.1 in Fedora 34, GNOME, as before. The screen resolution is full HD and I have a long list of other add-on's/buttons (20 ones) listed in the overflow menu (in case that should affect it). reproducible on two devices. (the other device does have a full HD screen but with HiDPI 125%, so even "less" pixel if you'd say it like this.)

Also, to add, the large size I guess is the initial issue. That I cannot use the button then there is just a followup problem. 🙃

Extension v1.0.20

@bwinton
Copy link
Owner

bwinton commented Aug 29, 2021

I still can't seem to replicate this. 😢
Could you go to about:addons, click "Debug Add-ons", and then "Inspect" SnoozeTabs, to try and figure out what's going wrong?
Screen Shot 2021-08-29 at 19 00 06

You may also need to "Disable Pop-up Autohide" in the meatball menu…
Screen Shot 2021-08-29 at 19 01 25

@rugk
Copy link
Contributor Author

rugk commented Aug 30, 2021

Crazy, though I found sth.:
grafik

ooks like some flexbox problem.

.times does seem to have a proper height.

Also though, if I remove that flex-grow: 2, it also does not work.

This here seems to fix it:

/* snooze.css | moz-extension://4d40debc-96f8-420b-91c3-418896754013/popup/snooze.css */

.panel > .content {
  /* flex-grow: 2; */
}

/* Element | moz-extension://4d40debc-96f8-420b-91c3-418896754013/popup/snooze.html */

#main {
  height: auto;
}

@rugk
Copy link
Contributor Author

rugk commented Aug 30, 2021

Okay, strange diff Firefox gave me, it creates a CSS and no patch, ok.

But here, that #main thing alone seems to fix it:

/* snooze.css | moz-extension://4d40debc-96f8-420b-91c3-418896754013/popup/snooze.css */

.panel.static.active {
  height: auto;
}

It looks/better now/goes into the correct direction:
grafik

Note that Firefox popup size system is somewhat complicated. In any case, once you have a popup as large as it is (the height in this case), it does not shrink it, it just keeps it's height.
That's why I guess the above result looks good. Without really compiling and testing a local copy of the extension I cannot be fully sure though, of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needinfo Needs a reply from the reporter.
Projects
None yet
Development

No branches or pull requests

2 participants