Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snoozing tab trees (from TreeStyleTab) loses data #515

Open
waldyrious opened this issue Dec 9, 2022 · 2 comments
Open

Snoozing tab trees (from TreeStyleTab) loses data #515

waldyrious opened this issue Dec 9, 2022 · 2 comments

Comments

@waldyrious
Copy link
Contributor

I use TreeStyleTab to nest tabs that are opened from links in an existing tab. I noticed that the "Snooze tab until..." menu entry appears when right-clicking on a tab that has such children tabs, and decided to test whether the snooze functionality would be able to handle such tab trees.

It didn't work, and made me lose data. Two scenarios are possible:

  1. The parent tab is expanded, with the children tabs visible underneath it. Snoozing this tab leads the parent tab to be closed, and the children tabs to be promoted up to its level (or whatever promotion behavior is configured in TreeStyleTab). This doesn't lose any tabs, since the closed tab is indeed restored later by SnoozeTabs; but the tree structure is lost. 😞
  2. The parent tab is collapsed. Snoozing this tab leads to the entire tree being closed (unless TreeStyleTab is configured otherwise). The parent tab is indeed restored later by SnoozeTabs, but the child tabs arent. This loses all the children tabs, as well as the tree structure. 😱

TreeStyleTab uses a simple format for storing trees of tabs in the bookmarks, which this extension could replicate: nesting levels are indicated by a > prefix in the title of the bookmark. For example, this tree:

image

...is stored in the bookmarks by TST like this:

image

(within a folder)

For an example of an extension that implements opening of tabs trees from bookmarks, in a way that's compatible with TreeStyleTab (i.e. preserves the nesting structure of the reopened tabs), see https://github.com/Lej77/bookmark-tree-for-tree-style-tab.

As a stopgap solution, this extension should warn when attempting to snooze tabs that have children tabs (if TreeStyleTab is present).

@Dimas-sc
Copy link

Dimas-sc commented Dec 9, 2022

I'd be very nice feature. Here using Sidebery for tree tabs.

@bwinton
Copy link
Owner

bwinton commented Dec 9, 2022

I don't use TreeStyleTabs, but if you wanted to post a patch that fixes this problem, I'd definitely look it over!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants