Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use current_dir, remove unused loop #271

Merged
merged 4 commits into from
Aug 31, 2023
Merged

test: use current_dir, remove unused loop #271

merged 4 commits into from
Aug 31, 2023

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Aug 18, 2023

Closes #

Changes

Why?

Tests could fail if current_dir has unexpected files and if action-routing is broken due to looping connections.

Trials Performed

Ran cargo test

@de-sh de-sh requested a review from tekjar August 18, 2023 08:19
@tekjar
Copy link
Contributor

tekjar commented Aug 23, 2023

These are hard failures due to bad config! We need to validate this right after config construction and panic if there are duplicates instead of bridge

@de-sh de-sh changed the title fix: shutdown when action routes clash test: remove unnecessary retries Aug 31, 2023
@de-sh de-sh changed the title test: remove unnecessary retries test: use current_dir, remove unused loop Aug 31, 2023
@de-sh de-sh merged commit d834110 into main Aug 31, 2023
2 checks passed
@de-sh de-sh deleted the determine-route branch August 31, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants