Enable a few features on more platforms. #1203
Conversation
Define `PollFlags::RDHUP` on FreeBSD, `AT_EACCESS` on Emscripten, and `ptsname` on Illumos.
* Enable a few features on more platforms. Define `PollFlags::RDHUP` on FreeBSD, `AT_EACCESS` on Emscripten, and `ptsname` on Illumos. * Enable `epoll` on solarish.
* Enable a few features on more platforms. Define `PollFlags::RDHUP` on FreeBSD, `AT_EACCESS` on Emscripten, and `ptsname` on Illumos. * Enable `epoll` on solarish.
| @@ -5,5 +5,5 @@ pub(crate) mod types; | |||
| #[cfg_attr(windows, path = "windows_syscalls.rs")] | |||
| pub(crate) mod syscalls; | |||
|
|
|||
| #[cfg(any(linux_kernel, target_os = "redox"))] | |||
| #[cfg(any(linux_kernel, solarish, target_os = "redox"))] | |||
There was a problem hiding this comment.
epoll is supported in illumos, but is it also supported in solaris? (I could not find the man page.)
https://illumos.org/man/7/epoll
Also, libc defines epoll-related stuff for solarish only in illumos.rs, so doesn't this actually cause a compile error in solaris?
https://github.com/search?q=repo%3Arust-lang%2Flibc+%2Fepoll_%2F+path%3Asrc%2Funix%2Fsolarish&type=code
There was a problem hiding this comment.
It does compile with the current libc crate. It appears the code you linked to here is only one day old and has not made it to a release yet. I've now filed #1208 to disable epoll support on Solaris in rustix.
There was a problem hiding this comment.
Thanks for the link and PR. The comment in in src/unix/solarish/mod.rs removed in the libc PR says:
// The epoll functions are actually only present on illumos. However,
// there are things using epoll on illumos (built using the
// x86_64-pc-solaris target) which would break until the illumos target is
// present in rustc.It appears to be what was used before illumos was added as its own target.
Define
PollFlags::RDHUPon FreeBSD,AT_EACCESSon Emscripten, andptsnameon Illumos.