Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dota2.get_players, dota2.get_patches & dota2webapi no longer working #17

Open
HugoTLR opened this issue Sep 3, 2022 · 1 comment
Open
Assignees

Comments

@HugoTLR
Copy link
Contributor

HugoTLR commented Sep 3, 2022

I wanted to rerun all tests from current project state to be sure my future PR hasn't break anything.

(HEAD detached at 3710936) ==> Last commit of this repo

get_players()

dota_obj = dota("appname")
players = dota_obj.get_players()

F:\Projets\liquipediapy (HEAD detached at 3710936)
(venv) λ python examples\dota_test.py
Traceback (most recent call last):
  File "examples\dota_test.py", line 5, in <module>
    players = dota_obj.get_players()
  File "C:\Users\***\AppData\Local\Programs\Python\Python38\lib\site-packages\liquipediapy\dota.py", line 31, in get_players
    key = index_values[i]
IndexError: list index out of range

get_patches()

dota_obj = dota("appname")
patches = dota_obj.get_patches()

F:\Projets\liquipediapy (HEAD detached at 3710936)
(venv) λ python examples\dota_test.py
Traceback (most recent call last):
  File "examples\dota_test.py", line 19, in <module>
    patches = dota_obj.get_patches()
  File "C:\Users\***\AppData\Local\Programs\Python\Python38\lib\site-packages\liquipediapy\dota.py", line 203, in get_patches
    key = index_values[i]
IndexError: list index out of range

dota2webapi

liquipediapy_object_dota = liquipediapy('appname','dota2')
match_details = liquipediapy_object_dota.dota2webapi('4225454337')

F:\Projets\liquipediapy (HEAD detached at 3710936)
(venv) λ python examples\liquid_test.py
Traceback (most recent call last):
  File "examples\liquid_test.py", line 7, in <module>
    match_details = liquipediapy_object_dota.dota2webapi('4225454337')
  File "C:\Users\***\AppData\Local\Programs\Python\Python38\lib\site-packages\liquipediapy\liquipediapy.py", line 40, in dota2webapi
    if res['dota2webapi']['isresult'] >= 1:
KeyError: 'dota2webapi'
@c00kie17 c00kie17 self-assigned this Nov 8, 2022
@c00kie17
Copy link
Owner

c00kie17 commented Nov 8, 2022

I need check whats wrong and fix these dont think they are related to your MR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants