Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SERAC: filter by contributor #810

Open
AntoineMarnat opened this issue Apr 5, 2020 · 4 comments
Open

SERAC: filter by contributor #810

AntoineMarnat opened this issue Apr 5, 2020 · 4 comments

Comments

@AntoineMarnat
Copy link
Contributor

We got a request per email: a Mountaineering club wanted to use SERAC for their RETEX. For their own purpose, they want to be able to extract the reports that are related to their club only.

Request: filter Xreport by user.

Implementation: few possibilities (they can be combined)

  • add a filter by user on the Xreport page, like the multicriteria filter for the outings.
  • add a link on the user profil page, between "outings" and "contributions" on the left. Possibility to show it only for profils of the type club/association.
  • add a private link "my Xreports" in the upper right menu, between "my contributions" and "my friends".

The choice should take care of privacy of users.

@cbeauchesne cbeauchesne transferred this issue from c2corg/c2c_ui Apr 29, 2020
@ataraxido
Copy link

I would go for the third solution : a private link ( and even maybe a check between the logged user and the requested user over the API ).
What do you think ?

@cbeauchesne
Copy link
Member

On API side :

  • URL must stick to the outing model : /xreports?u=123456
  • For a start, we can be cautious, and allow this url only for the logged user, and moderator

On UI side :

  • Until the access is restricted to user own's xreport, just add a link for logged users on https://www.camptocamp.org/xreports : see my xreports. You have quite the same link on /outings "See my outings".

@AntoineMarnat
Copy link
Contributor Author

@cbeauchesne : I do not see a "See my outings" button for logged users on /outings. I only see a link to /outings?u=123456 on the profil page /profiles/123456. It corresponds to solution 2, it may be visible only if you are on your own profil page.

I just had a look, xreports may only be linked to the author - if he does not wish to remain anonymous. Not to a generic user, like outings. For the request we are dealing with, of a Mountaineering club, this is a problem: member of the club should be able to associate their xreport to the profil of the club via their own account.

@cbeauchesne
Copy link
Member

image

if he does not wish to remain anonymous.

For the anonymous reports, there is nothing we can do: we do not save original author.

I understand a little more the request. They want to be able to add more than one users to an xreport. In their use case, it will be the reporter, and the club's camptocamp account. Right ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants