fix: fix number check issue

c4p-n1ck · Nov 18, 2021 · 6e3f8b1 · 6e3f8b1
1 parent 2a20559
commit 6e3f8b1
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/lib/find.js b/lib/find.js
@@ -57,7 +57,14 @@ function find (by, value, strict) {
     if (!(by in findBy)) {
       reject(new Error(`do not support find by "${by}"`))
     } else {
-      if (by === 'pid' && typeof value !== 'number') { reject(new Error('pid must be a number')) } else if (by === 'port' && typeof value !== 'number') { reject(new Error('port must be a number')) } else { findBy[by](value, strict).then(resolve, reject) }
+      const isNumber = /^\d+$/.test(value)
+      if (by === 'pid' && !isNumber) {
+        reject(new Error('pid must be a number'))
+      } else if (by === 'port' && !isNumber) {
+        reject(new Error('port must be a number'))
+      } else {
+        findBy[by](value, strict).then(resolve, reject)
+      }
     }
   })
 }