Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send message in PR when merging would create release #41

Closed
jonathan-mayer opened this issue Sep 10, 2024 · 0 comments · Fixed by #44, #42 or #52
Closed

Send message in PR when merging would create release #41

jonathan-mayer opened this issue Sep 10, 2024 · 0 comments · Fixed by #44, #42 or #52
Assignees
Labels
enhancement New feature or request

Comments

@jonathan-mayer
Copy link
Member

jonathan-mayer commented Sep 10, 2024

Issue

Currently if someone isn't careful when reviewing a PR the workflows could automatically create an unwanted Release.

Problem to solve

We need a way of easily being warned when merging a PR would result in a new Release

Further details

Depends on #42

Proposal

Create a Workflow or adjust the check_version workflow to check if merging the PR would result in a new release.

It's important that even if the change was made after the PR opened (by committing a Chart.yaml version bump after opening the PR) the message still has to be sent.

It would be even better if the maintainer had to accept these risks before being able to merge. eg. a manually triggered pipeline that has to complete before merging is allowed, or by commenting or reacting with an emoji to the message.

Who can address the issue

Other links/references

@jonathan-mayer jonathan-mayer added the enhancement New feature or request label Sep 10, 2024
@jonathan-mayer jonathan-mayer changed the title Draft: Send message in PR when merging would create release Send message in PR when merging would create release Sep 11, 2024
@JTaeuber JTaeuber self-assigned this Sep 13, 2024
@JTaeuber JTaeuber mentioned this issue Sep 16, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment