Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/overlapping timespan check #36

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

Feat/overlapping timespan check #36

wants to merge 18 commits into from

Conversation

jon4skl
Copy link
Contributor

@jon4skl jon4skl commented Sep 6, 2024

Motivation

needed to open a new pull request

Changes

Tests done

TODO

  • I've assigned myself to this PR

@jon4skl jon4skl self-assigned this Sep 6, 2024
@jonathan-mayer
Copy link
Member

Resolved the Merge conflicts. Before we merge we should wait on a review from @JTaeuber

@jon4skl jon4skl added the enhancement New feature or request label Sep 11, 2024
JTaeuber
JTaeuber requested changes Sep 12, 2024
View reviewed changes
internal/pkg/values/timespan.go Show resolved Hide resolved
internal/pkg/values/timespan.go Show resolved Hide resolved
internal/pkg/values/util.go Show resolved Hide resolved
internal/pkg/values/util.go Outdated Show resolved Hide resolved
internal/pkg/values/util.go Outdated Show resolved Hide resolved
internal/pkg/values/util.go Outdated Show resolved Hide resolved
JTaeuber
JTaeuber previously approved these changes Sep 12, 2024
View reviewed changes
jonathan-mayer
jonathan-mayer previously approved these changes Sep 13, 2024
View reviewed changes
JTaeuber
JTaeuber requested changes Sep 13, 2024
View reviewed changes
Copy link
Member

@JTaeuber JTaeuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check doesn't work yet.

JTaeuber
JTaeuber requested changes Sep 13, 2024
View reviewed changes
internal/pkg/values/timespan.go Outdated Show resolved Hide resolved
@jonathan-mayer jonathan-mayer marked this pull request as draft September 13, 2024 09:53
@jonathan-mayer
Copy link
Member

There is a pretty big problem with the current implementation.
image
This has to be resolved first. I dont think this will be resolved any time soon though, i will push a test for this and we should let this feature wait for a bit

@jonathan-mayer jonathan-mayer linked an issue Sep 19, 2024 that may be closed by this pull request
Implement overlapping timespans incompatibility check #8
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JTaeuber JTaeuber JTaeuber requested changes

@jonathan-mayer jonathan-mayer jonathan-mayer left review comments

Requested changes must be addressed to merge this pull request.

Assignees

@jon4skl jon4skl

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement overlapping timespans incompatibility check
3 participants
@jon4skl @jonathan-mayer @JTaeuber