Enhance CI Workflow: Check for Version Bump and appVersion Changes #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…change feat: additional approval on Version change
Fovty
requested review from
jonathan-mayer,
JTaeuber and
jon4skl
as code owners
jonathan-mayer
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Just some naming, maybe @JTaeuber will find something but the rest looks good to me
jonathan-mayer
approved these changes
Sep 12, 2024
JTaeuber
approved these changes
Sep 12, 2024
jonathan-mayer
added a commit
that referenced
this pull request
Sep 16, 2024
* refactor create_release workflow to make automatic release * add check_version workflow * refactor doc´ker build * refactor helm build * refactor create_release.yaml * change version to 1.0.0 * fix path ref * add missing v * refactor workflows * Enhance CI Workflow: Check for Version Bump and appVersion Changes (#44) * feat: additional approval on Version change * fix: combine version bump check and approve by label * fix: adjust label name * fix: remove tag comparison * fix: base_ref * fix: some naming changes * Fix syntax Co-authored-by: Jonathan Mayer <[email protected]> * refactor check-for-release.yaml * fix dependency * resolve merge conflicts * add label removing * chore: syntax * change message * removed not needed if checks * removal of new release --------- Co-authored-by: Johannes <[email protected]> Co-authored-by: Jonathan Mayer <[email protected]>
jonathan-mayer
added a commit
that referenced
this pull request
Sep 16, 2024
* refactor create_release workflow to make automatic release * add check_version workflow * refactor doc´ker build * refactor helm build * refactor create_release.yaml * change version to 1.0.0 * fix path ref * add missing v * refactor workflows * Enhance CI Workflow: Check for Version Bump and appVersion Changes (#44) * feat: additional approval on Version change * fix: combine version bump check and approve by label * fix: adjust label name * fix: remove tag comparison * fix: base_ref * fix: some naming changes * Fix syntax Co-authored-by: Jonathan Mayer <[email protected]> * refactor check-for-release.yaml * fix dependency * resolve merge conflicts * add label removing * chore: syntax * change message * removed not needed if checks * removal of new release * fix errors in workflows --------- Co-authored-by: Johannes <[email protected]> Co-authored-by: Jonathan Mayer <[email protected]>
jonathan-mayer
added a commit
that referenced
this pull request
Sep 16, 2024
* refactor create_release workflow to make automatic release * add check_version workflow * refactor doc´ker build * refactor helm build * refactor create_release.yaml * change version to 1.0.0 * fix path ref * add missing v * refactor workflows * Enhance CI Workflow: Check for Version Bump and appVersion Changes (#44) * feat: additional approval on Version change * fix: combine version bump check and approve by label * fix: adjust label name * fix: remove tag comparison * fix: base_ref * fix: some naming changes * Fix syntax Co-authored-by: Jonathan Mayer <[email protected]> * refactor check-for-release.yaml * fix dependency * resolve merge conflicts * add label removing * chore: syntax * change message * removed not needed if checks * removal of new release * fix errors in workflows * fix appVersion variable mismatch --------- Co-authored-by: Johannes <[email protected]> Co-authored-by: Jonathan Mayer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This change improves the existing CI workflow by adding a check for both version bumps and changes to the
appVersionin theChart.yaml. It aims to ensure that any changes to key versioning information are caught and flagged during the pull request process, providing maintainers the ability to block merges if necessary.Changes
appVersionbetween the PR and themainbranch.appVersionchange is detected.releaselabel is applied.Tests done
Chart.yaml.releaselabel.appVersionfield.TODO
Ensure that the branch protection rules for the main branch enforce the
Version Bump Checkstatus check.The workflow requires write access to contents and pull requests to set statuses and post comments. Make sure the following permissions are enabled for GitHub Actions:
writewriteI've assigned myself to this PR