Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/add helm docs #67

Open
wants to merge 23 commits into
base: feat/add-docusaurus
Choose a base branch
from
Open

Feat/add helm docs #67

wants to merge 23 commits into from

Conversation

JTaeuber
Copy link
Member

@JTaeuber JTaeuber commented Nov 4, 2024 •
edited by jonathan-mayer
Loading

Motivation

Adding documentation for the Helm Chart

Refers to #38

Changes

  • fixed pre-commit email
  • refactored values.yaml
  • added documentation pages for the helm chart
  • added global links file

Tests done

Ran the site locally

TODO

Make links to arguments and environment variable pages.

@JTaeuber JTaeuber added the documentation Improvements or additions to documentation label Nov 4, 2024
jonathan-mayer
jonathan-mayer reviewed Nov 5, 2024
View reviewed changes
Copy link
Member

@jonathan-mayer jonathan-mayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should rename the Values folder to values to match its id

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-mayer jonathan-mayer jonathan-mayer requested changes

@jon4skl jon4skl Awaiting requested review from jon4skl jon4skl is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@JTaeuber JTaeuber

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JTaeuber @jonathan-mayer