Chore/change prettier hook #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Interesting that pip is already installed.
I would normally have not wanted to have it installed twice but it shouldn't since pip is just going to say that the requirement is already met.
One consideration would be to move the autoupdate under the check so we don't have to install it manually.
The pre commit workfow would automatically run on the updated versions of the hooks once the workflow pushes the pre-commit-config.yaml changes.
|
While we are here we could also consider changing the check for release workflow to only run when the pull request is trying to merge to main. |
This reverts commit 028ee29.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Change outdated pre-commit hooks and auto update them.
Changes