Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better alertmanager templates handling #43

Open
puffitos opened this issue Oct 17, 2024 · 0 comments
Open

Better alertmanager templates handling #43

puffitos opened this issue Oct 17, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@puffitos
Copy link
Member

Description

The alertmanager default template (the rancher one) is hardcoded in the values.yaml, which makes it hard to read, interpret and change. If one wants to edit the template, they must edit the values.yaml and write a new template directly in the YAML file.

Proposal

Use the configMaps value to mount our default as a configMap. The default config of the alertmanager must also be changed to accommodate for this change (https://github.com/prometheus-community/helm-charts/blob/21021a2799659dbb892c29ab661ad8cbb7bb2a1b/charts/kube-prometheus-stack/values.yaml#L338).

The ConfigMap can then be created as a Template in our chart, as the grafana config maps are created.

@puffitos puffitos added the enhancement New feature or request label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant