Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: A method for storing / loading general client settings #3

Open
cinnamon-bun opened this issue Aug 14, 2018 · 4 comments
Open

Comments

@cinnamon-bun
Copy link
Member

Something like

client.getSettings()
client.saveSettings(settingsObject)

Where settingsObject is an arbitrary JSONable object.

This would be for local client settings like notification options, color themes or light mode vs dark mode, auto-emojification, etc.

@cinnamon-bun cinnamon-bun changed the title An API for general client settings Idea: A method for storing / loading general client settings Aug 14, 2018
@hackergrrl
Copy link
Member

hackergrrl commented Jun 20, 2020

We now have ~/.cabal/v1/config.yaml, but cabal-client doesn't expose it yet (clients are accessing it directly). This seems like a perfect place to expose settings like this.

@cblgh
Copy link
Member

cblgh commented Jun 20, 2020

@noffle that's the cli config file. i remember @nikolaiwarner wanting to keep cli and desktop configs separate

other than that, yeah i've been thinking along similar lines of re-using ~/.cabal/v1/config.yml :)

@hackergrrl
Copy link
Member

hackergrrl commented Jun 20, 2020 via email

@nikolaiwarner
Copy link
Member

I'm cool with consolidating. I think I advocated for them be as similar as possible so config files could be interchangeable and sharable.

Also, Desktop stores its config as json atm.

Would future client softwares register their preferred subkey with cabal-client?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants