-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
httpcaddyfile: Implement force_automate
#6712
base: master
Are you sure you want to change the base?
Conversation
What's annoying about this is it's hard to test a real-world scenario because the TLS automation stuff has special conditions for But I did confirm at least that using I'm not able to test with a real domain right now (time/effort) so I can't confirm with certainty that the change to automation policies has the intended effect. The behaviour I'm seeing is that all hostnames are having certs automated, even a wildcard with a loaded cert, even if Configuring like |
Tested, works. While I cannot speak to the implementation and the general approach, I successfully tested this in production 🙈 with real domains and services. |
In another test I ran |
You just ran adapt with your old version of Caddy. Make sure you run adapt with the correct binary. Thanks for testing! Appreciated. |
You are absolutely right :D Sorry, for the confusion. |
Closes #5933
I think this should work according to the JSON config output, but I didn't actually test it at runtime to verify that it yields the expected behaviour. @mholt you had a repro set up locally if you want to give it a spin while reviewing.