Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContextPropagators lost in TestWorkflowEnvironment #621

Open
WellingR opened this issue Jul 6, 2021 · 0 comments
Open

ContextPropagators lost in TestWorkflowEnvironment #621

WellingR opened this issue Jul 6, 2021 · 0 comments
Labels

Comments

@WellingR
Copy link

WellingR commented Jul 6, 2021

While enabling a ContextPropagators to include MDC in logging I found that it did not work during my tests.

After some investigation I found out that the TestWorkflowEnvironmentInternal calls WorkflowClientOptions.newBuilder(options). Which creates a copy of the options but without the context propagators.

On first glance fixing this seems as simple as just setting the context propagators in WorkflowClientOptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants