Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update vis.js #192

Closed
mojoaxel opened this issue Sep 15, 2020 · 1 comment · Fixed by #209
Closed

update vis.js #192

mojoaxel opened this issue Sep 15, 2020 · 1 comment · Fixed by #209

Comments

@mojoaxel
Copy link

mojoaxel commented Sep 15, 2020 •
edited
Loading

vis is depecated!
You should switch to the new an up-to-date vis-timeline!
just-at-uber added a commit that referenced this issue Oct 22, 2020
@just-at-uber
fixed timeline dependency to use latest version. Current version is d…
0edae75 
…epricated. see issue #192
@just-at-uber just-at-uber mentioned this issue Oct 22, 2020
Merged
just-at-uber added a commit that referenced this issue Oct 22, 2020
@just-at-uber
Update vis library (#209)
a933099 
* fixed timeline dependency to use latest version. Current version is depricated. see issue #192

* fixing failing integration test
@mojoaxel
Copy link
Author

🎉

just-at-uber added a commit that referenced this issue Oct 23, 2020
@just-at-uber
Fix/no workflow found (#211)
31f8c8a 
* removing encodeURIComponent to avoid double decoding URL

* locking all versions so they dont auto fetch latest minor versions

* revert package file fix

* fixed timeline dependency to use latest version. Current version is depricated. see issue #192

* fixing failing integration test

* only escape forward slash

* adding console logs to help debugging

* moving logic into helper and fixing at router level.

* adding unit tests

* removing escaped runId as this is generated from server and is gauranteed to be a UUID
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update vis library cadence-workflow/cadence-web
2 participants
@mojoaxel @just-at-uber