Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next release considerations #14

Closed
7 tasks done
caio opened this issue Oct 24, 2017 · 4 comments
Closed
7 tasks done

Next release considerations #14

caio opened this issue Oct 24, 2017 · 4 comments

Comments

@caio
Copy link
Owner

caio commented Oct 24, 2017

Working on #12 I stumbled on several things I would like to change which would trigger api breakage (forcing a 2.0.0 release):

  • Remove the centroid abstraction: it's useless in its current encantation, however it's exposed publicly
  • Get rid of all explicit panic()s (the most annoying one is gone on avl-wip already)
  • Configurable RNG (mostly to benefit testing)

Other things that would be nice to work on and don't necessarily force a major release:

  • (Dropped from v2: doesn't seem worth it) More deterministic tests: currently running them with -run TestName yields different (but still correct of course) results when compared with running them all.
  • Test different distributions: requires writing some code or adding test-only dependencies
  • (Dropped from v2: blocked) Sync up merge formats after the reference implementation changes (issue87)
  • Investigate prefix sum optimization ideas: using a binary indexed tree or a plain cache should improve speed noticeably without a big memory cost: d89c9f2
@caio
Copy link
Owner Author

caio commented Oct 25, 2017

I'll be updating branch v2 whenever I tick one of these boxes.

Permanent compare link: master...v2

@caio
Copy link
Owner Author

caio commented Oct 27, 2017

More notable changes going into this branch (dumping here so that it's easier for me to write the release):

  • TDigest.Len() has been dropped: ef6ba11
  • TDigest.Count() has been introduced (and it's not what Len() was): cb481be
  • We can register more than 4B samples now: 4378773

@caio
Copy link
Owner Author

caio commented Oct 28, 2017

I've now added a CDF(float64) method: 7e8db71

Next time I sit down on this I'll release v2.0.0

@caio
Copy link
Owner Author

caio commented Oct 30, 2017

Released!

@caio caio closed this as completed Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant