Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pixels to store the amount of shift in raster correction #351

Open
ecobost opened this issue Apr 6, 2019 · 0 comments
Open

Use pixels to store the amount of shift in raster correction #351

ecobost opened this issue Apr 6, 2019 · 0 comments

Comments

@ecobost
Copy link
Collaborator

ecobost commented Apr 6, 2019

Right now for raster correction (see background below) we use the temporal fill fraction during scanning (amount of time the laser was on during the scanning of each line) and record the correction as the angle needed to add to the laser beam to correct for the beam shuttering being out of sync. There is no need or benefit for that; it just makes the code more complex and hard to understand. We don't need to care about the physics of the scanning, all we need to know is that the odd rows and even rows may be out of sync and compute the amount of pixels that the odd rows should be shifted[^1] to match the even rows; we get the exact same result with much more interpretable code and quantity (pixel_shift vs raster_phase).
[^1] During the actual correction, we should shift the odd rows half this amount to the left and the even rows half to the right to drop about the same amount of info from either side. This is how it's done right now.

Background

Scanning happens one row at a time in a sigsaw motion; the first row is scanned from left to right then the second is scanned from right to left and so on. The laser shuts off at the end of one line while it stops and reverses direction and turns back on at the start of the new line:
scan field
Sometimes the timing of the shutting off and on is out of phase and all odd lines don't align with all the even lines(left). Raster correction solves this(right):
rastercorrection_9329-1-2_f2png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant