Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enrollment index: Update for CalFresh #1917

Closed
14 tasks done
Tracked by #1878
thekaveman opened this issue Feb 28, 2024 · 2 comments · Fixed by #1968
Closed
14 tasks done
Tracked by #1878

Enrollment index: Update for CalFresh #1917

thekaveman opened this issue Feb 28, 2024 · 2 comments · Fixed by #1968
Assignees
Labels
front-end HTML/CSS/JavaScript and Django templates i18n Copy: Language files or Django i18n framework

Comments

@thekaveman
Copy link
Member

thekaveman commented Feb 28, 2024

This page will be substantially different from other flows for CalFresh eligibility.

Full page

image

Informational Alert component

image

Figma links

Acceptance Criteria

  • Headline and first paragraph remains the same.
  • Remove the “Please use a debit and credit card by Visa or Mastercard.” paragraph that is in the other flows’ screens.
  • New component - Alert box (Informational alert), links to the same CalFresh modal from Create new CalFresh Cardholder informational modal #1918
    • Space between bottom of media item and top of alert box: 48px
    • Space between bottom of alert box and call to action button: 64px
    • Bottom margin of alert box heading: 4px
    • Background yellow: #FFF1D0
    • Border yellow: #FDB714
    • Link: #045B86
    • Link focus ring: #045B86
    • Border width: 8px
    • Left padding from border to text: 16px
    • Right padding from text to edge: 16px
    • Top/bottom padding from text to edge: 16px
@thekaveman thekaveman changed the title Enrollment index: Headline and first paragraph remains the same. Remove the “Please use a debit and credit card by Visa or Mastercard.” paragraph that is in the other flows’ screens. Enrollment index: Update CalFresh Feb 28, 2024
@thekaveman thekaveman added front-end HTML/CSS/JavaScript and Django templates i18n Copy: Language files or Django i18n framework labels Feb 28, 2024
@thekaveman thekaveman changed the title Enrollment index: Update CalFresh Enrollment index: Update for CalFresh Feb 28, 2024
@thekaveman thekaveman self-assigned this Mar 20, 2024
@thekaveman thekaveman moved this from Todo to In Progress in Digital Services Mar 20, 2024
@thekaveman
Copy link
Member Author

thekaveman commented Mar 20, 2024

Starting to get into this and one immediate question that comes up:

How to override the enrollment:index template for CalFresh?

Background

We typically override templates by storing the name of the template to use on a particular model. Today we have:

  • AuthProvider stores its sign_out_button_template and sign_out_link_template for defining those UI components
  • EligibilityVerifier stores the selection_label_template and start_template for defining the eligibility phase
  • TransitAgency stores an index_template and help_template for its own homepage and help page, an eligibility_index_template for the beginning of its eligibility phase, and an enrollment_success_template for the end of its enrollment phase

Options

I can see 3 options for how to override the enrollment:index template:

  • PaymentProcessor: I actually don't think this will work, since each agency only has a single payment processor instance, and we need this template to be specific to the flow -- including for posterity
  • EligibilityVerifier: this would work in the sense that we typically create a verifier per flow, but it sort of feels wrong though? Since we're talking about enrollment specifically, which is entirely outside of the eligibility phase
  • EligibilityType: of the options, this is the one that makes the most sense to me. We already store some enrollment information here (e.g. group_id and the expiry fields), and of course this is the most specific in terms of the flow, i.e. we always have a new instance for each flow.

@angela-tran am I missing any options here? Any thoughts on the above options? Can you think of another way we might want to override this template that doesn't involve a model field?

@angela-tran
Copy link
Member

@angela-tran am I missing any options here? Any thoughts on the above options? Can you think of another way we might want to override this template that doesn't involve a model field?

I agree that it makes the most sense to store it on the EligibilityType. Since the message is specific to the flow, our only options are either EligibilityVerifier or EligibilityType, and it does seem wrong to put enrollment information on the verifier.

@thekaveman thekaveman moved this from In Progress to In Review in Digital Services Mar 25, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Digital Services Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end HTML/CSS/JavaScript and Django templates i18n Copy: Language files or Django i18n framework
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants