Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model refactor: EligibilityVerifier.start_template default value #2063

Closed
3 tasks done
thekaveman opened this issue Apr 29, 2024 · 0 comments · Fixed by #2272
Closed
3 tasks done

Model refactor: EligibilityVerifier.start_template default value #2063

thekaveman opened this issue Apr 29, 2024 · 0 comments · Fixed by #2272
Assignees
Labels
back-end Django views, sessions, middleware, models, migrations etc. chore Chores and tasks for code cleanup, dev experience, admin/configuration settings, etc.

Comments

@thekaveman
Copy link
Member

thekaveman commented Apr 29, 2024

In #1968 we introduced a new model field to hold a template with a default value that can be overridden if needed. The default was stored directly in the model/database rather than separated as a string in the views.

We decided that this is the best approach for these types of cases, so we need to refactor the existing EligibilityVerifier.start_template to conform to this approach.

Acceptance Criteria

Additional context

The same approach is being taken in #2053

This could be done as part of #2238

@thekaveman thekaveman added chore Chores and tasks for code cleanup, dev experience, admin/configuration settings, etc. back-end Django views, sessions, middleware, models, migrations etc. labels Apr 29, 2024
@thekaveman thekaveman moved this from Todo to Stretch in Digital Services Apr 29, 2024
@thekaveman thekaveman added this to the Admin tool: agency users milestone Jul 23, 2024
@thekaveman thekaveman changed the title Refactor eligibility start template default value Model refactor: EligibilityVerifier.start_template default value Jul 23, 2024
@thekaveman thekaveman self-assigned this Aug 2, 2024
@thekaveman thekaveman moved this from Stretch to In progress in Digital Services Aug 2, 2024
@thekaveman thekaveman moved this from In progress to In review in Digital Services Aug 2, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in Digital Services Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end Django views, sessions, middleware, models, migrations etc. chore Chores and tasks for code cleanup, dev experience, admin/configuration settings, etc.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant