Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help page breaks when adding a new EligibilityVerifier through admin interface #2168

Closed
angela-tran opened this issue Jun 14, 2024 · 1 comment · Fixed by #2169
Closed

Help page breaks when adding a new EligibilityVerifier through admin interface #2168

angela-tran opened this issue Jun 14, 2024 · 1 comment · Fixed by #2169
Assignees
Labels
bug Something isn't working

Comments

@angela-tran
Copy link
Member

angela-tran commented Jun 14, 2024

To Reproduce

Steps to reproduce the behavior:

  1. Start with a database that has just loaded fixtures (./bin/reset_db.sh)
    • At this point, Help page works when starting from / or after choosing a transit provider
  2. Go into admin interface, and add a new EligibilityVerifier, leaving the help_template blank, which is a valid thing to do. Click Save.
  3. Add that Eligibility Verifier to one of the TransitAgencys
  4. Go to / and select that TransitAgency
  5. Click on the Help link at the bottom of the page
  6. See error

Expected behavior

The Help page should show the help sections for any of the TransitAgency's verifiers that specify a help_template.

Screenshots

DEBUG off
image

DEBUG on
image

Additional context

#1970 introduced help_template

Django docs on null parameter on TextField: https://docs.djangoproject.com/en/5.0/ref/models/fields/#null

the Django convention is to use the empty string, not NULL

@angela-tran angela-tran added the bug Something isn't working label Jun 14, 2024
@cal-itp-sentry
Copy link

Sentry issue: BENEFITS-83

@angela-tran angela-tran moved this from Todo to In progress in Digital Services Jun 14, 2024
@angela-tran angela-tran self-assigned this Jun 14, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Digital Services Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant