Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The version flag should not involve a config file #32

Closed
thekaveman opened this issue Mar 13, 2024 · 0 comments · Fixed by #38
Closed

The version flag should not involve a config file #32

thekaveman opened this issue Mar 13, 2024 · 0 comments · Fixed by #38
Assignees
Labels
bug Something isn't working cli New command line interface feature implementation or refactor

Comments

@thekaveman
Copy link
Member

thekaveman commented Mar 13, 2024

From work on #31:

The last problem to overcome was that littlepay -v was not only printing the version, but also creating a new config file since this workflow doesn't point it at existing file. This caused the output of littlepay -v to be something like this:

Creating config file: 
/home/runner/.littlepay/config.yaml 
0.1.dev1g9bfec47 

which leads to the error message about a multi-line output variable not being set correctly.

I resolved this by just calling littlepay before doing anything else.

Originally posted by @angela-tran in #31 (comment)

Just printing the version on the CLI should not involve a configuration file, instead short-cutting to print the version directly.

@thekaveman thekaveman changed the title The version flag should simply print the version The version flag should not involve a config file Mar 13, 2024
@thekaveman thekaveman added bug Something isn't working cli New command line interface feature implementation or refactor labels Mar 13, 2024
@thekaveman thekaveman moved this to Todo in Digital Services Mar 13, 2024
@thekaveman thekaveman self-assigned this Mar 21, 2024
@thekaveman thekaveman moved this from Todo to In Progress in Digital Services Mar 21, 2024
@thekaveman thekaveman moved this from In Progress to In Review in Digital Services Mar 21, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Digital Services Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cli New command line interface feature implementation or refactor
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant