Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommendations for Updates #15

Open
alead opened this issue Jun 7, 2021 · 0 comments
Open

Recommendations for Updates #15

alead opened this issue Jun 7, 2021 · 0 comments

Comments

@alead
Copy link

alead commented Jun 7, 2021

  • Provide description of dataframe/input that enters the model
  • Provide a list of options of function for data type of input from which user can choose:
    -- Example:

func_type = {"marker": neighborhood_to_marker, "cluster": neighborhood_to_cluster, "avg_marker": neighborhood_to_avg_marker, "count": neighborhood_to_count}

if TYPE == "marker" or TYPE == "avg_marker":
neighborhood_feature_fn = functools.partial(func_type[TYPE], markers = markers)
else:
neighborhood_feature_fn = functools.partial(func_type[TYPE])

  • Make "anchor cell" more generalizable/define more clearly (since most data sets will probably have all cells as anchors
  • Enable user to plot 1 FOV at a time (plot_samples_in_a_row does not work when only one fov number is input)
    -- Maybe rename visualization functions as "sample" instead of "tumor" since not all MIBI images will be of tumors
  • Enable user to save resulting plots (currently plots are produced within the function, so to plot, it would require user to modify function)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant