Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rewrite github-trending examples #122

Open
pkarw opened this issue Dec 14, 2024 · 3 comments
Open

feat: rewrite github-trending examples #122

pkarw opened this issue Dec 14, 2024 · 3 comments

Comments

@pkarw
Copy link
Collaborator

pkarw commented Dec 14, 2024

Right now these examples are using firecrawl which is suboptimal. Moreover the whole content of this page added to context often causes max-tokens limit exceptions.

Let's switch to GitHub API instead

@grabbou
Copy link
Collaborator

grabbou commented Dec 16, 2024

So, maybe:

  • we remove this example? no need for extra maintenance hassle, and we need to keep them quality
  • we remove firecrawl tool, if unstable?

@pkarw
Copy link
Collaborator Author

pkarw commented Dec 18, 2024

Yea, I think it's good idea to remove github_trending which I've had removed in the recent PR (about the BDD restring framework). The other one github_trending_vector works pretty much stable so I'd keep it for now

@grabbou
Copy link
Collaborator

grabbou commented Dec 19, 2024

Okay, so sounds like we can or perhaps should close this issue when we merge that PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants