Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permissions/rows #267

Merged
merged 53 commits into from
Oct 20, 2023
Merged

Permissions/rows #267

merged 53 commits into from
Oct 20, 2023

Conversation

thimo-schneider
Copy link
Contributor

@github-actions
Copy link

github-actions bot commented Feb 24, 2023 •
edited
Loading

Unit Test Results

956 tests  +9   938 ✔️  -   1   4m 52s ⏱️ +21s
118 suites +1     18 💤 +10 
118 files   +1       0 ❌ ±  0 

Results for commit 6ff3a5b. ± Comparison against base commit 32a9fce.

♻️ This comment has been updated with latest results.

zingmane
zingmane reviewed Oct 5, 2023
View reviewed changes
Copy link
Member

@zingmane zingmane left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was fehlt noch?

  • Tests für history annotation changed
  • Anpassung openApi docs (patch row, was noch?)
  • Anpassung auth permission doc
  • Runtime error, wenn mehr als eine row permission übergeben wird
  • Runtime error, wenn der Endpoint rows/annotations verwendet wird
  • Rebase auf master fehlt noch
  • Anpassungen Frontend

src/main/scala/com/campudus/tableaux/router/TableauxRouter.scala Outdated Show resolved Hide resolved
src/main/scala/com/campudus/tableaux/database/model/tableaux/RowModel.scala Outdated Show resolved Hide resolved
src/test/scala/com/campudus/tableaux/api/content/LinkTest.scala Outdated Show resolved Hide resolved
src/main/scala/com/campudus/tableaux/database/model/TableauxModel.scala Outdated Show resolved Hide resolved
@zingmane zingmane force-pushed the permissions/rows branch 3 times, most recently from 0d31e2e to 9c7a164 Compare October 9, 2023 08:06
@github-actions
Copy link

github-actions bot commented Oct 9, 2023 •
edited
Loading

File Coverage
All files 88% ✅
com/campudus/tableaux/exceptions.scala 0% ❌
com/campudus/tableaux/exceptions.scala 0% ❌
com/campudus/tableaux/arguments.scala 90% ✅
com/campudus/tableaux/Starter.scala 74% ❌
com/campudus/tableaux/cache/CacheVerticle.scala 76% ❌
com/campudus/tableaux/cache/CacheClient.scala 68% ❌
com/campudus/tableaux/controller/SystemController.scala 99% ✅
com/campudus/tableaux/controller/TableauxController.scala 96% ✅
com/campudus/tableaux/controller/StructureController.scala 91% ✅
com/campudus/tableaux/controller/MediaController.scala 80% ✅
com/campudus/tableaux/database/historyType.scala 7% ❌
com/campudus/tableaux/database/languageType.scala 86% ✅
com/campudus/tableaux/database/historyType.scala 66% ❌
com/campudus/tableaux/database/database.scala 96% ✅
com/campudus/tableaux/database/database.scala 81% ✅
com/campudus/tableaux/database/database.scala 97% ✅
com/campudus/tableaux/database/domain/column.scala 68% ❌
com/campudus/tableaux/database/domain/column.scala 71% ❌
com/campudus/tableaux/database/domain/column.scala 95% ✅
com/campudus/tableaux/database/domain/table.scala 96% ✅
com/campudus/tableaux/database/domain/service.scala 62% ❌
com/campudus/tableaux/database/domain/service.scala 0% ❌
com/campudus/tableaux/database/domain/column.scala 77% ❌
com/campudus/tableaux/database/domain/column.scala 48% ❌
com/campudus/tableaux/database/domain/annotation.scala 0% ❌
com/campudus/tableaux/database/domain/history.scala 84% ✅
com/campudus/tableaux/database/domain/column.scala 68% ❌
com/campudus/tableaux/database/domain/column.scala 0% ❌
com/campudus/tableaux/database/domain/annotation.scala 83% ✅
com/campudus/tableaux/database/domain/annotation.scala 80% ✅
com/campudus/tableaux/database/domain/table.scala 99% ✅
com/campudus/tableaux/database/domain/column.scala 95% ✅
com/campudus/tableaux/database/domain/file.scala 72% ❌
com/campudus/tableaux/database/domain/domainobject.scala 99% ✅
com/campudus/tableaux/database/domain/column.scala 92% ✅
com/campudus/tableaux/database/domain/column.scala 78% ❌
com/campudus/tableaux/database/domain/domainobject.scala 93% ✅
com/campudus/tableaux/database/model/HistoryModel.scala 96% ✅
com/campudus/tableaux/database/model/AttachmentModel.scala 82% ✅
com/campudus/tableaux/database/model/TableauxModel.scala 93% ✅
com/campudus/tableaux/database/model/StructureModel.scala 95% ✅
com/campudus/tableaux/database/model/SystemModel.scala 84% ✅
com/campudus/tableaux/database/model/FileModel.scala 94% ✅
com/campudus/tableaux/database/model/structure/ColumnModel.scala 89% ✅
com/campudus/tableaux/database/model/structure/TableModel.scala 84% ✅
com/campudus/tableaux/database/model/structure/TableGroupModel.scala 79% ❌
com/campudus/tableaux/database/model/structure/ColumnModel.scala 88% ✅
com/campudus/tableaux/database/model/tableaux/RowModel.scala 92% ✅
com/campudus/tableaux/database/model/tableaux/RowModel.scala 91% ✅
com/campudus/tableaux/database/model/tableaux/RowModel.scala 93% ✅
com/campudus/tableaux/helper/FileUtils.scala 74% ❌
com/campudus/tableaux/helper/JsonUtils.scala 94% ✅
com/campudus/tableaux/helper/ResultChecker.scala 96% ✅
com/campudus/tableaux/helper/IdentifierFlattener.scala 83% ✅
com/campudus/tableaux/router/DocumentationRouter.scala 21% ❌
com/campudus/tableaux/router/BaseRouter.scala 62% ❌
com/campudus/tableaux/router/SystemRouter.scala 89% ✅
com/campudus/tableaux/router/MediaRouter.scala 72% ❌
com/campudus/tableaux/router/TableauxRouter.scala 82% ✅
com/campudus/tableaux/router/StructureRouter.scala 99% ✅
com/campudus/tableaux/router/RouterRegistry.scala 73% ❌
com/campudus/tableaux/router/auth/KeycloakAuthHandler.scala 72% ❌
com/campudus/tableaux/router/auth/permission/Condition.scala 89% ✅
com/campudus/tableaux/router/auth/permission/Condition.scala 74% ❌
com/campudus/tableaux/router/auth/permission/Condition.scala 87% ✅
com/campudus/tableaux/router/auth/permission/RoleModel.scala 86% ✅
com/campudus/tableaux/router/auth/permission/RoleModel.scala 0% ❌
com/campudus/tableaux/router/auth/permission/Condition.scala 90% ✅
com/campudus/tableaux/router/auth/permission/Condition.scala 79% ❌
com/campudus/tableaux/router/auth/permission/Action.scala 97% ✅
com/campudus/tableaux/router/auth/permission/Condition.scala 85% ✅
com/campudus/tableaux/router/auth/permission/TableauxUser.scala 63% ❌
com/campudus/tableaux/verticles/JsonSchemaValidator/JsonSchemaValidator.scala 86% ✅

Minimum allowed coverage is 80%

Generated by 🐒 cobertura-action against 0baa7a0

@zingmane zingmane marked this pull request as draft October 10, 2023 14:25
@zingmane zingmane force-pushed the permissions/rows branch 2 times, most recently from 7de11c4 to 6ff3a5b Compare October 11, 2023 13:46
@github-actions
Copy link

github-actions bot commented Oct 11, 2023 •
edited
Loading

Test Results

972 tests   964 ✔️  3m 34s ⏱️
120 suites      8 💤
120 files        0 ❌

Results for commit 0baa7a0.

♻️ This comment has been updated with latest results.

@zingmane zingmane marked this pull request as ready for review October 16, 2023 14:45
zingmane added 23 commits October 20, 2023 09:40
@zingmane
fix fallback getRowPermission for not existing row
763fed0
@zingmane
update open api doc,
4b97f9c 
API/parameters should be equal over http verbs
@zingmane
add preparation for row permission insert
d3d2448 
on create row
@zingmane
write rowPermission to user_table
46c93d7
@zingmane
write rowPermission history to user_table_history
1e41886
@zingmane
fix error with optional getJson
eaa7c5d
@zingmane
fix some code quality issues
91a6ce0
@zingmane
add router, controller and model for row perms
aa68724
@zingmane
add row permission tests
ff6c432
@zingmane
change endpoint b/c DELETE doesn't allow body
ae62c2f
@zingmane
do not response row permissions
75c9191
@zingmane
move tests to separat RowPermissionTest file
33705b6
@zingmane
temp
e75116c
@zingmane
refactor
847638b
@zingmane
one test failing
c063a3d
@zingmane
all row permission tests green
7410f94
@zingmane
add more row permission tests
8feafc5
@zingmane
add default testRole to be able to change rowPerms
0fdf2f4
@zingmane
refactor and clean up
3f343b5
@zingmane
add test for hidden identifier rows
fddb150
@zingmane
add *.jsonc files to gitignore
52056c9
@zingmane
do not pass method to isMatching, not needed
5c96081
@zingmane
reactivate matrix build
41c303a
@zingmane zingmane requested a review from Zwergal October 20, 2023 12:54
Zwergal
Zwergal approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@Zwergal Zwergal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vom Code her sieht es gut aus. Bin über alles mal drüber geflogen.

@zingmane zingmane merged commit ec75c45 into master Oct 20, 2023
9 checks passed
@zingmane zingmane deleted the permissions/rows branch October 20, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zingmane zingmane zingmane left review comments

@Zwergal Zwergal Zwergal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thimo-schneider @zingmane @Zwergal @s-tschne