Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smooth 8.7 migration linting: no-job-worker-user-task #177

Closed
Skaiir opened this issue Oct 21, 2024 · 3 comments · Fixed by #179
Closed

Smooth 8.7 migration linting: no-job-worker-user-task #177

Skaiir opened this issue Oct 21, 2024 · 3 comments · Fixed by #179
Assignees
Labels
enhancement New feature or request rules

Comments

@Skaiir
Copy link
Contributor

Skaiir commented Oct 21, 2024

The rule should detect the following modeling patterns

  • Incorrect
    <bpmn:userTask id="Activity_18h160l" name="Job worker">
      <bpmn:extensionElements>
        <zeebe:formDefinition formKey="X" />
      </bpmn:extensionElements>
      <bpmn:incoming>Flow_12l5h67</bpmn:incoming>
      <bpmn:outgoing>Flow_1g357gi</bpmn:outgoing>
    </bpmn:userTask>
  • Correct
    <bpmn:userTask id="Activity_1s8r6ix" name="Zeebe">
      <bpmn:extensionElements>
        <zeebe:userTask />
        <zeebe:formDefinition externalReference="Y" />
      </bpmn:extensionElements>
      <bpmn:incoming>Flow_16godsg</bpmn:incoming>
      <bpmn:outgoing>Flow_1w0i494</bpmn:outgoing>
    </bpmn:userTask>

The key difference being the detection of the zeebe:userTask element.

How does the rule improve the BPMN diagram?

Following 8.7, non-zeebe user-tasks are no longer going to be supported. So we need to indicate this as an error.

Rule Details

  • Name: no-job-worker-user-task
  • Default notification level: error

What alternatives did you consider?

n/a

@Skaiir Skaiir added enhancement New feature or request rules labels Oct 21, 2024
@Skaiir Skaiir self-assigned this Oct 21, 2024
@jarekdanielak
Copy link

Is there any timeline for this? Do you plan to contribute or should somebody from bpmn-io team pick it up?

@Skaiir
Copy link
Contributor Author

Skaiir commented Oct 22, 2024

@jarekdanielak I'm taking care of it, should have this and #178 PR'd today.

Skaiir added a commit that referenced this issue Oct 22, 2024
@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Oct 22, 2024
Skaiir added a commit that referenced this issue Oct 22, 2024
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Oct 22, 2024
Skaiir added a commit that referenced this issue Oct 22, 2024
@Skaiir
Copy link
Contributor Author

Skaiir commented Oct 22, 2024

philippfromme pushed a commit that referenced this issue Oct 23, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request rules
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants