Fix version tag linting #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An error will be reported by the `no-binding-type` rule so we don't need another error for the version tag itself. Related to camunda/camunda-modeler#4519
nikku
approved these changes
Sep 13, 2024
|
@philippfromme anything learning you can share with the team regarding design of "validation", based off this PR? Likely relevant for the future. |
nikku
reviewed
Sep 16, 2024
|
Released as v2.26.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no-version-tagrule will not lint thezeebe:versionTagattribute anymore, the scenario of binding by version tag with Camunda <8.6 is covered by theno-binding-typerule; as a result there will only be one lint error instead of two for what's essentially the same problemversion-tagrule will lint version tags and report and report an error if they're emptyRelated to camunda/camunda-modeler#4519
Required by camunda/linting#117