Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs dark mode v1.0 #4510

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Docs dark mode v1.0 #4510

wants to merge 18 commits into from

Conversation

akeller
Copy link
Member

@akeller akeller commented Oct 24, 2024

Description

Add a "dark mode" option to the docs web site, and check/refine CSS styles and content for any issues and to align branding with product dark mode.

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@akeller akeller added the deploy Stand up a temporary docs site with this PR label Oct 24, 2024
@github-actions github-actions bot temporarily deployed to camunda-docs October 24, 2024 20:43 Destroyed
@github-actions github-actions bot temporarily deployed to camunda-docs October 24, 2024 21:21 Destroyed
@akeller akeller added the hold This issue is parked, do not merge. label Oct 24, 2024
@github-actions github-actions bot temporarily deployed to camunda-docs October 24, 2024 21:59 Destroyed
@github-actions github-actions bot temporarily deployed to camunda-docs November 14, 2024 12:05 Destroyed
@mesellings
Copy link
Contributor

Did some work on this today, still to check:

  • Admonitions
  • Tabs
  • API ref styles
  • Some images as discussed (transparent SVGs)

But other than that, it's already looking good (homepage and page content)! Shouldn't take much to finish off and get into review for the team.

@akeller FYI, I think this will be done before the hackathon, so might scrap that idea.

@github-actions github-actions bot temporarily deployed to camunda-docs November 14, 2024 17:22 Destroyed
@mesellings
Copy link
Contributor

SVGs non-blocking:
Investigated page: http://localhost:3000/docs/next/components/modeler/bpmn/bpmn-coverage

  • All images render sufficiently, though black outlined ones could be clearer.
  • Don't want to add a blanket background colour to .SVGs
  • Suggest follow-up work on this page to go through these images and improve for dark mode.

@mesellings mesellings changed the title dark mode? Docs dark mode Nov 15, 2024
@mesellings mesellings marked this pull request as ready for review November 15, 2024 12:01
@mesellings mesellings added kind/enhancement Issues related with enhancing existing documentation or the documentation structure (nice to have) component:docs Documentation improvements, including new or updated content labels Nov 15, 2024
@mesellings mesellings requested a review from a team November 15, 2024 12:01
@mesellings
Copy link
Contributor

mesellings commented Nov 15, 2024

@camunda/tech-writers The first iteration of dark mode is now ready for review in this PR:

https://preview.docs.camunda.cloud/pr-4510/index.html

Changes made as follows:

  • General dark mode styling/colours follows the product dark mode where possible.
  • Home page edited to suit dark mode.
  • Enable/disable using the icon at the top right of the banner.

Things to look at and check if we need to make further mods, or if they are 'okay as is' for now.

  • Admonition colours
  • Tabs (I changed them to 'buttons in dark mode)
  • Link colour (blue works better than orange in dark mode and matches product)
  • API ref styles
  • Images (might do some follow-up work on a few specific pages with transparent SVGs, but they are usable for now)

@mesellings mesellings changed the title Docs dark mode Docs dark mode v1.0 Nov 15, 2024
@github-actions github-actions bot temporarily deployed to camunda-docs November 15, 2024 12:19 Destroyed
Copy link
Contributor

@conceptualshark conceptualshark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super cool, thank you for all the time you've put into making this feasible!! 🙌

  • The admonitions, like you mentioned, including things like <details>, look very bright for the theme. When stacked with other elements (code blocks or admonitions nested in <details>) I think this becomes more apparent.
Screenshot 2024-11-15 at 8 29 29 AM
  • The badge buttons also look very bright:
Screenshot 2024-11-15 at 8 31 38 AM
  • The Algolia search seems to use a different default dark mode, but I don't think this necessarily needs to be updated in a V1 push.

I'm not sure how important any of these are! Nothing looks dramatic, everything seems to be functioning on the pages I'm reviewing in the areas you've asked us to take a look at. I'm stoked for this to be possible!

@github-actions github-actions bot temporarily deployed to camunda-docs November 19, 2024 20:49 Destroyed
@github-actions github-actions bot temporarily deployed to camunda-docs November 20, 2024 14:01 Destroyed
@mesellings
Copy link
Contributor

Had some time at the RSG so took a look at badges, links, and general accessibility 👍

@github-actions github-actions bot temporarily deployed to camunda-docs November 20, 2024 14:33 Destroyed
@github-actions github-actions bot temporarily deployed to camunda-docs November 24, 2024 15:54 Destroyed
@github-actions github-actions bot temporarily deployed to camunda-docs November 24, 2024 16:25 Destroyed
@github-actions github-actions bot temporarily deployed to camunda-docs November 26, 2024 09:47 Destroyed
@github-actions github-actions bot temporarily deployed to camunda-docs November 26, 2024 10:31 Destroyed
@github-actions github-actions bot temporarily deployed to camunda-docs November 26, 2024 15:43 Destroyed
@github-actions github-actions bot temporarily deployed to camunda-docs November 27, 2024 09:29 Destroyed
Copy link
Contributor

The preview environment relating to the commit 198c387 has successfully been deployed. You can access it at https://preview.docs.camunda.cloud/pr-4510/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:docs Documentation improvements, including new or updated content deploy Stand up a temporary docs site with this PR hold This issue is parked, do not merge. kind/enhancement Issues related with enhancing existing documentation or the documentation structure (nice to have)
Projects
Status: 👀 In Review
Development

Successfully merging this pull request may close these issues.

3 participants