-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs dark mode v1.0 #4510
base: main
Are you sure you want to change the base?
Docs dark mode v1.0 #4510
Conversation
Did some work on this today, still to check:
But other than that, it's already looking good (homepage and page content)! Shouldn't take much to finish off and get into review for the team. @akeller FYI, I think this will be done before the hackathon, so might scrap that idea. |
SVGs non-blocking:
|
@camunda/tech-writers The first iteration of dark mode is now ready for review in this PR: https://preview.docs.camunda.cloud/pr-4510/index.html Changes made as follows:
Things to look at and check if we need to make further mods, or if they are 'okay as is' for now.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is super cool, thank you for all the time you've put into making this feasible!! 🙌
- The admonitions, like you mentioned, including things like
<details>
, look very bright for the theme. When stacked with other elements (code blocks or admonitions nested in<details>
) I think this becomes more apparent.
- The badge buttons also look very bright:
- The Algolia search seems to use a different default dark mode, but I don't think this necessarily needs to be updated in a V1 push.
I'm not sure how important any of these are! Nothing looks dramatic, everything seems to be functioning on the pages I'm reviewing in the areas you've asked us to take a look at. I'm stoked for this to be possible!
Had some time at the RSG so took a look at badges, links, and general accessibility 👍 |
The preview environment relating to the commit 198c387 has successfully been deployed. You can access it at https://preview.docs.camunda.cloud/pr-4510/index.html |
Description
Add a "dark mode" option to the docs web site, and check/refine CSS styles and content for any issues and to align branding with product dark mode.
When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).