Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I can not search the DRD #3975

Closed
marstamm opened this issue Nov 9, 2023 · 3 comments · Fixed by #3977
Closed

I can not search the DRD #3975

marstamm opened this issue Nov 9, 2023 · 3 comments · Fixed by #3977
Assignees
@barmac
Labels
bug Something isn't working
Milestone
M71

Comments

@marstamm
Copy link
Member

marstamm commented Nov 9, 2023

Describe the bug

With the recent version bumps of dmn-js, we implemented search in DRD: bpmn-io/dmn-js#792

This is also available on the demo, but does not work in the modeler

Steps to reproduce

  1. Open a DRD
  2. press Ctrl+F
  3. nothing happens

Expected behavior

I can search the Diagram

Environment

Camunda Modeler system information

  • Version: 5.17.0
  • Operating System: Linux x86_64 amd64
  • Plugins: autosave-plugin, test, test-client, test-editor-events, test-lint-rules, test-script-error
  • Execution Platform: DMN - Camunda 8

Additional context

No response
@marstamm marstamm added the bug Something isn't working label Nov 9, 2023
@barmac
Copy link
Collaborator

barmac commented Nov 9, 2023

I guess the custom keyboard component in the Modeler may block this :/

@barmac
Copy link
Collaborator

barmac commented Nov 9, 2023

I see, it's not allowed in the menu actions.

barmac added a commit that referenced this issue Nov 9, 2023
@barmac
fix: integrate DRD find
7a0dc9e 
Closes #3975
@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Nov 9, 2023
@barmac barmac mentioned this issue Nov 9, 2023
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Nov 9, 2023
@nikku nikku added this to the M71 milestone Nov 9, 2023
marstamm pushed a commit that referenced this issue Nov 13, 2023
@barmac @marstamm
fix: integrate DRD find
a7fd547 
Closes #3975
@marstamm
Copy link
Member Author

fixed via #3977

@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 13, 2023
@smbea smbea mentioned this issue Dec 5, 2023
Closed
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barmac barmac

Labels
bug Something isn't working
Projects
None yet
Milestone
M71
Development

Successfully merging a pull request may close this issue.

fix: integrate DRD find camunda/camunda-modeler
3 participants
@nikku @marstamm @barmac