-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: docker-compose with opensearch #768
Conversation
yevhen-cap
commented
Aug 9, 2024
- core
- camunda platform
- core - camunda platform
- core - camunda platform
5a7c2c2
to
f510c62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
84d3734
to
50a8d7c
Compare
50a8d7c
to
8ebc229
Compare
Hi @yevhen-cap It seems like OpenSearch cluster never turns green and always stays yellow. Can you please take a look? |
Likely related to this opensearch-project/security-analytics#1352 |
…form into platform-opensearch
…form into platform-opensearch
f17b516
to
8c980ff
Compare
- health check workaround
8c980ff
to
ed78e98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a new entire Docker Compose file will increase the maintenance effort and duplication.
We need to do that via env var files instead of doing it with a new file.
c5e87b0
to
ed78e98
Compare
* initial unified compose file * removed ssl * remove healthcheck * removed test data * fix: core changes - added .env configs - removed sh file - unified docker-compose.yml and docker-compose-core.yml * fix: core changes - added recommended config - removed ssl - added .env configs - removed sh file - unified docker-compose.yml and docker-compose-core.yml --------- Co-authored-by: Yevhen Podluzhnyi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Few optional comments.
Let's wait review/approval from @aabouzaid before we merge. Thank you!
- fixed comments - added params for opensearch
0b72c8a
to
92aeb29
Compare
cfdb641
to
10d0dda
Compare
10d0dda
to
5b48adf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you 👍