Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: docker-compose with opensearch #768

Merged
merged 15 commits into from
Sep 11, 2024
Merged

feat: docker-compose with opensearch #768

merged 15 commits into from
Sep 11, 2024

Conversation

yevhen-cap
Copy link
Contributor

  • core
  • camunda platform
image image image image

- core
- camunda platform
@CLAassistant
Copy link

CLAassistant commented Aug 9, 2024

CLA assistant check
All committers have signed the CLA.

@igpetrov igpetrov removed the request for review from slolatte August 12, 2024 06:43
Copy link
Contributor

@igpetrov igpetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igpetrov igpetrov force-pushed the platform-opensearch branch 3 times, most recently from 84d3734 to 50a8d7c Compare August 15, 2024 17:42
@igpetrov
Copy link
Contributor

Hi @yevhen-cap

It seems like OpenSearch cluster never turns green and always stays yellow. Can you please take a look?

@igpetrov igpetrov self-requested a review August 15, 2024 18:04
@igpetrov
Copy link
Contributor

Hi @yevhen-cap

It seems like OpenSearch cluster never turns green and always stays yellow. Can you please take a look?

Likely related to this opensearch-project/security-analytics#1352

@yevhen-cap yevhen-cap force-pushed the platform-opensearch branch 2 times, most recently from f17b516 to 8c980ff Compare August 21, 2024 05:55
- health check workaround
Copy link
Member

@aabouzaid aabouzaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a new entire Docker Compose file will increase the maintenance effort and duplication.
We need to do that via env var files instead of doing it with a new file.

* initial unified compose file

* removed ssl

* remove healthcheck

* removed test data

* fix: core changes

- added .env configs
- removed sh file
- unified docker-compose.yml and docker-compose-core.yml

* fix: core changes

- added recommended config
- removed ssl
- added .env configs
- removed sh file
- unified docker-compose.yml and docker-compose-core.yml

---------

Co-authored-by: Yevhen Podluzhnyi <[email protected]>
Copy link
Contributor

@igpetrov igpetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Few optional comments.
Let's wait review/approval from @aabouzaid before we merge. Thank you!

.env Outdated Show resolved Hide resolved
docker-compose-core.yaml Show resolved Hide resolved
- fixed comments
- added params for opensearch
@yevhen-cap yevhen-cap force-pushed the platform-opensearch branch 2 times, most recently from 0b72c8a to 92aeb29 Compare September 10, 2024 12:06
@yevhen-cap yevhen-cap force-pushed the platform-opensearch branch 5 times, most recently from cfdb641 to 10d0dda Compare September 10, 2024 14:05
Copy link
Member

@aabouzaid aabouzaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you 👍

@aabouzaid aabouzaid merged commit d913ae6 into main Sep 11, 2024
11 checks passed
@aabouzaid aabouzaid deleted the platform-opensearch branch September 11, 2024 12:20
@aabouzaid aabouzaid added the enhancement New feature or request label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants