Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output ids in cycle #212

Open
nhomble opened this issue Apr 17, 2023 · 2 comments
Open

Output ids in cycle #212

nhomble opened this issue Apr 17, 2023 · 2 comments

Comments

@nhomble
Copy link

nhomble commented Apr 17, 2023

Is your feature request related to a problem? Please describe.
It is difficult to determine the cycle in a DMN from the current message in the Camunda modeler. My only way to figure this out is to run the parser locally and set a breakpoint.

      Left(Failure(
        "Invalid DMN model: Cyclic dependencies between decisions detected."))

Describe the solution you'd like
I'd like to see the ids of the impacting decisions added to the failure message.

Related issues
#207

@saig0 saig0 removed their assignment Apr 18, 2023
@saig0
Copy link
Member

saig0 commented Apr 18, 2023

@nhomble thank you for reporting. 👍

This sounds like a reasonable improvement. But maybe not the most important one. I assume that the cyclic dependency is obvious when looking at the DRD. But feel free to share an example to demonstrate the issue.

@nhomble
Copy link
Author

nhomble commented Apr 18, 2023

I agree that the DRD should be sufficient which is why I created #213 out of surprise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants